Defining a zipkin2.reporter.Reporter results in two reporter beans as the auto-configured AsyncReporter does not back off #35455
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
be-hase
commented
May 17, 2023
| assertThat(context).hasBean("customReporter"); | ||
| assertThat(context).hasSingleBean(Reporter.class); | ||
| }); | ||
| this.contextRunner.withUserConfiguration(SenderConfiguration.class, CustomConfiguration.class) |
There was a problem hiding this comment.
It seems that the test code was not correct because it did not include SenderConfiguration.class.
1 task
spring-projects-issues
added
the
status: waiting-for-triage
wilkinsona
changed the title
wilkinsona
added
type: bug
…tion.spanReporter)
be-hase
force-pushed
the
fix-async-reporter
branch
from
0736e76 to
4db9b52
Compare
philwebb
pushed a commit
that referenced
this pull request
May 17, 2023
Update `ReporterConfiguration` so that `spanReporter` back off if a `Reporter` bean is defined. Prior to this commit, only `AsyncReporter` beans would be considered. See gh-35455
philwebb
added a commit
that referenced
this pull request
May 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
from this PR: #35424
Modifications
ZipkinConfigurations.ReporterConfiguration
I want to use a
Reporter<Span>that I created myself(bean configuration).For some reason, the current
AsyncReporter<Span>is used, so if I configure the bean by myself, twoReporter<Span>are created.