Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add missing @ServiceConnection in importing container declarations example #35333

Closed
wants to merge 1 commit into from
Closed

Add missing @ServiceConnection in importing container declarations example #35333

wants to merge 1 commit into from

Conversation

quaff
Copy link
Contributor

@quaff quaff commented May 6, 2023 •
edited
Loading

Fix #35332

@quaff quaff mentioned this pull request May 6, 2023
Closed
@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label May 6, 2023
@wilkinsona wilkinsona changed the title Add missing @ServiceConnection Add missing @ServiceConnection in importing container declarations example May 9, 2023
@wilkinsona
Copy link
Member

Thanks for the PR but I'm not sure that @ServiceConnection is missing here. As described in the text that comes before it, the code is intended to be an example of pure Testcontainers code. The subsequent tip then explains that you can use @ServiceConnection or @DynamicPropertySource. You don't have to use @ServiceConnection so I don't think it really belongs in the earlier pure-Testcontainers example.

@wilkinsona wilkinsona closed this May 9, 2023
@wilkinsona wilkinsona added status: declined A suggestion or change that we don't feel we should currently apply and removed status: waiting-for-triage An issue we've not yet triaged labels May 9, 2023
@quaff
Copy link
Contributor Author

quaff commented May 10, 2023

Thanks for the PR but I'm not sure that @ServiceConnection is missing here. As described in the text that comes before it, the code is intended to be an example of pure Testcontainers code. The subsequent tip then explains that you can use @ServiceConnection or @DynamicPropertySource. You don't have to use @ServiceConnection so I don't think it really belongs in the earlier pure-Testcontainers example.

The typo should be fixed at least, I've created another PR #35369

@wilkinsona wilkinsona mentioned this pull request May 25, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
status: declined A suggestion or change that we don't feel we should currently apply
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

@ImportTestcontainers doesn't work
3 participants
@quaff @wilkinsona @spring-projects-issues