Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Document audience support in OAuth2 resource server #35286

Closed
wants to merge 9 commits into from
Closed

Document audience support in OAuth2 resource server #35286

wants to merge 9 commits into from

Conversation

bikash30851
Copy link
Contributor

Closes #34848

@pivotal-cla
Copy link

@bikash30851 Please sign the Contributor License Agreement!

Click here to manually synchronize the status of this Pull Request.

See the FAQ for frequently asked questions.

@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label May 4, 2023
@pivotal-cla
Copy link

@bikash30851 Thank you for signing the Contributor License Agreement!

@bikash30851
Copy link
Contributor Author

@snicoll I have completed the documentation for issue #34848. Feel free to make suggestions. Thank you

@at758
Copy link

at758 commented May 7, 2023 •
edited
Loading

Can you squash commits to one clean commit? Having multiple commits is good during development but spoils the commit history. I am unsure if the package has rules to squash during a merge.

@wilkinsona
Copy link
Member

@at758, thanks for trying to help but if we wanted the commits to be squashed we would ask @bikash30851 to so do.

@bikash30851, your commits are fine as they are. If necessary when can squash them as part of merging your pull request.

wilkinsona
wilkinsona requested changes May 9, 2023
View reviewed changes
Copy link
Member

@wilkinsona wilkinsona left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR. I've left a couple of comments for your consideration.

spring-boot-project/spring-boot-docs/src/docs/asciidoc/web/spring-security.adoc Outdated Show resolved Hide resolved
spring-boot-project/spring-boot-docs/src/docs/asciidoc/web/spring-security.adoc Outdated Show resolved Hide resolved
@wilkinsona wilkinsona added the status: waiting-for-feedback We need additional information before we can continue label May 9, 2023
@wilkinsona wilkinsona mentioned this pull request May 9, 2023
Closed
@bikash30851
Update spring-security.adoc
b0b9b85 
Incorporated feedback from PR review.
@bikash30851
Copy link
Contributor Author

Thank you for your review. I have incorporated your feedback into the documentation. @wilkinsona

@spring-projects-issues spring-projects-issues added status: feedback-provided Feedback has been provided and removed status: waiting-for-feedback We need additional information before we can continue labels May 9, 2023
@wilkinsona wilkinsona added type: documentation A documentation update and removed status: waiting-for-triage An issue we've not yet triaged status: feedback-provided Feedback has been provided labels May 10, 2023
@wilkinsona wilkinsona added this to the 2.7.x milestone May 10, 2023
@wilkinsona wilkinsona added the status: waiting-for-feedback We need additional information before we can continue label May 10, 2023
@bikash30851
Copy link
Contributor Author

@wilkinsona do I need to do anything else for this PR to be merged? Thank you!

@spring-projects-issues spring-projects-issues added status: feedback-provided Feedback has been provided and removed status: waiting-for-feedback We need additional information before we can continue labels May 23, 2023
@wilkinsona wilkinsona mentioned this pull request May 25, 2023
Closed
@wilkinsona wilkinsona modified the milestones: 2.7.x, 2.7.13 May 25, 2023
wilkinsona pushed a commit that referenced this pull request May 25, 2023
@bikash30851 @wilkinsona
Document audience support in Oauth2 resource server
13c5c6e 
See gh-35286
wilkinsona added a commit that referenced this pull request May 25, 2023
@wilkinsona
Polish "Document audience support in Oauth2 resource server"
f452a86 
See gh-35286
@wilkinsona wilkinsona changed the title Documenting audience support in Oauth2 resource server Document audience support in Oauth2 resource server May 25, 2023
@wilkinsona wilkinsona changed the title Document audience support in Oauth2 resource server Document audience support in OAuth2 resource server May 25, 2023
@wilkinsona wilkinsona changed the title Document audience support in OAuth2 resource server Document audience support in OAuth2 resource server May 25, 2023
@wilkinsona wilkinsona removed the status: feedback-provided Feedback has been provided label May 25, 2023
@wilkinsona
Copy link
Member

@bikash30851 Thanks very much for making your first contribution to Spring Boot.

@izeye izeye mentioned this pull request Jun 13, 2023
Closed
@Netyyyy Netyyyy mentioned this pull request Jul 3, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@at758 at758 at758 left review comments

@wilkinsona wilkinsona wilkinsona requested changes

Assignees
No one assigned
Labels
type: documentation A documentation update
Projects
None yet
Milestone
2.7.13
Development

Successfully merging this pull request may close these issues.

Document audience support in Oauth2 resource server
5 participants
@bikash30851 @pivotal-cla @at758 @wilkinsona @spring-projects-issues