-
Notifications
You must be signed in to change notification settings - Fork 40.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve Kubernetes liveness and readiness probes customization documentation #34978
Improve Kubernetes liveness and readiness probes customization documentation #34978
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the proposal. Configuring an additional path is already documented and we link to this documentation from the introduction of the section on probes. I'm not too keen on duplicating information between the two sections. Perhaps we could add another cross-reference instead?
a8e9060
to
4432dc0
Compare
4432dc0
to
20e3262
Compare
Yes, you understand it correctly. The probes documentation notes that the probes are implemented as health groups:
And the documentation on health groups to which it links describes how to customise the additional paths of any health group. This is the section in your screenshot above. |
20e3262
to
8e698b1
Compare
I have changed wordings and added link to groups docs. What do you think? |
…ntation Add tests for liveness and readiness probes
8e698b1
to
a2bea45
Compare
tests fixed, rebased to recent upstream/main |
We'd like to make the change to the documentation. We don't feel the tests are necessary as we think we have sufficient coverage elsewhere. |
Thanks very much @bedla, this is now in 2.7.x and merged forwards to all supported branches. |
Hi,
when I was looking into docs how to customize k8s liveness and readiness probes, I was not able to find it explicitly how to do it.
This PR add tests and improves documentation little bit.
What do you think?
Thx
Ivos