Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BatchProperties has an outdated reference to JPA #34844

Closed

Conversation

benelog
Copy link
Contributor

@benelog benelog commented Apr 3, 2023

Since JpaBatchConfigurer.java was removed, BatchAutoConfiguration.getIsolationLevelForCreate() is the only method that determines the default value for spring.batch.jdbc.isolation-level-for-create.

BatchAutoConfiguration.getIsolationLevelForCreate() does not consider the use of JPA.

With this PR, it is expected that the following documents will be fixed as well.

https://docs.spring.io/spring-boot/docs/current/reference/htmlsingle/#application-properties.integration.spring.batch.jdbc.isolation-level-for-create

@benelog benelog changed the title Delete out-of-date description in BatchProperties Delete an outdated description in BatchProperties Apr 3, 2023
@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label Apr 3, 2023
@benelog benelog force-pushed the fix-doc-BatchProperties branch from 99b8681 to 88a6442 Compare April 3, 2023 21:09
@benelog benelog changed the title Delete an outdated description in BatchProperties Delete the outdated description in BatchProperties Apr 3, 2023
@scottfrederick scottfrederick added type: documentation A documentation update and removed status: waiting-for-triage An issue we've not yet triaged labels Apr 4, 2023
@scottfrederick scottfrederick modified the milestones: 3.x, 3.0.x Apr 4, 2023
@benelog benelog force-pushed the fix-doc-BatchProperties branch from 88a6442 to 6fa34a3 Compare April 6, 2023 04:29
@snicoll snicoll self-assigned this Apr 11, 2023
@snicoll snicoll changed the title Delete the outdated description in BatchProperties BatchProperties has an outdated reference to JPA Apr 11, 2023
@snicoll snicoll modified the milestones: 3.0.x, 3.0.6 Apr 11, 2023
snicoll pushed a commit that referenced this pull request Apr 11, 2023
snicoll added a commit that referenced this pull request Apr 11, 2023
@snicoll snicoll closed this in dd09fbc Apr 11, 2023
@snicoll
Copy link
Member

snicoll commented Apr 11, 2023

Thanks again, @benelog

With this PR, it is expected that the following documents will be fixed as well.

Yes, it is generated automatically from the description.

@benelog benelog deleted the fix-doc-BatchProperties branch April 11, 2023 23:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: documentation A documentation update
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants