Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

defaultTracingObservationHandler is not ordered as documented #34216

Closed
wants to merge 1 commit into from

Conversation

ttddyy
Copy link
Contributor

@ttddyy ttddyy commented Feb 16, 2023

The javadoc on MicrometerTracingAutoConfiguration.DEFAULT_TRACING_OBSERVATION_HANDLER_ORDER says it is a @Order value for the defaultTracingObservationHandler bean.
However, in the code, this constant is not applied to the defaultTracingObservationHandler bean definition.

This PR specifies the missing @Order on the defaultTracingObservationHandler bean.

@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label Feb 16, 2023
@mhalbritter mhalbritter added type: enhancement A general enhancement theme: observability Issues related to observability type: bug A general bug and removed status: waiting-for-triage An issue we've not yet triaged type: enhancement A general enhancement labels Feb 17, 2023
@mhalbritter mhalbritter modified the milestones: 3.1.x, 3.0.x Feb 17, 2023
@wilkinsona wilkinsona changed the title Specify @Order to the defaultTracingObservationHandler bean definition defaultTracingObservationHandler is not ordered as documented Feb 20, 2023
@wilkinsona wilkinsona modified the milestones: 3.0.x, 3.0.4 Feb 24, 2023
wilkinsona pushed a commit that referenced this pull request Feb 24, 2023
@wilkinsona
Copy link
Member

Thanks very much, @ttddyy.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
theme: observability Issues related to observability type: bug A general bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants