-
Notifications
You must be signed in to change notification settings - Fork 40.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tracer library HTTP instrumentation is auto-configured unnecessarily #33287
Closed
jonatan-ivanov
wants to merge
2
commits into
spring-projects:main
from
jonatan-ivanov:tracer-http-support-removal
Closed
Tracer library HTTP instrumentation is auto-configured unnecessarily #33287
jonatan-ivanov
wants to merge
2
commits into
spring-projects:main
from
jonatan-ivanov:tracer-http-support-removal
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jonatan-ivanov
changed the title
Tracer librar HTTP instrumentation support removal
Tracer library HTTP instrumentation support removal
Nov 21, 2022
spring-projects-issues
added
the
status: waiting-for-triage
An issue we've not yet triaged
label
Nov 21, 2022
LGTM! |
wilkinsona
changed the title
Tracer library HTTP instrumentation support removal
Tracer library HTTP instrumentation is auto-configured unnecessarily
Nov 22, 2022
wilkinsona
added
type: bug
A general bug
and removed
status: waiting-for-triage
An issue we've not yet triaged
labels
Nov 22, 2022
wilkinsona
pushed a commit
that referenced
this pull request
Nov 22, 2022
ndwlocatieservices
added a commit
to ndwnu/nls-accessibility-map
that referenced
this pull request
Aug 19, 2024
…o v3 This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [nu.ndw.nls.geometry:nls-geometry](https://spring.io/projects/spring-boot) ([source](https://github.com/spring-projects/spring-boot)) | compile | major | `2.2.0` -> `3.0.0` | --- ### Release Notes <details> <summary>spring-projects/spring-boot (nu.ndw.nls.geometry:nls-geometry)</summary> ### [`v3.0.0`](https://github.com/spring-projects/spring-boot/releases/tag/v3.0.0) [Compare Source](spring-projects/spring-boot@v2.2.1.RELEASE...v3.0.0) See the [Release notes for 3.0](https://github.com/spring-projects/spring-boot/wiki/Spring-Boot-3.0-Release-Notes) for upgrade instructions and details of new features. #### ⭐ New Features - Provide a configuration property for the observation patterns of Spring Integration components [#​33099](spring-projects/spring-boot#33099) #### 🐞 Bug Fixes - io.micrometer.tracing.Tracer on the classpath breaks AOT processing for tests [#​33298](spring-projects/spring-boot#33298) - Tracer library HTTP instrumentation is auto-configured unnecessarily [#​33287](spring-projects/spring-boot#33287) - Auto-configuration ignores user-provided ObservationConventions [#​33285](spring-projects/spring-boot#33285) - `ScheduledBeanLazyInitializationExcludeFilter` is auto-configured even when annotation-based scheduled has not been enabled [#​33284](spring-projects/spring-boot#33284) - SpringBootContextLoader prints banner twice when using a `@ContextHierarchy` [#​33263](spring-projects/spring-boot#33263) - Properties migrator causes an application to fail to start if it tries to map a property whose metadata data entry contains an invalid configuration property name [#​33250](spring-projects/spring-boot#33250) - Wavefront MeterRegistryCustomizer is not applying application tags from application.properties [#​33244](spring-projects/spring-boot#33244) - Actuator responses no longer format timestamps as ISO-8601 [#​33236](spring-projects/spring-boot#33236) - Configuration property is not bound in a native image when property has get, set, and is methods [#​33232](spring-projects/spring-boot#33232) - Configuration property binding does not deal with bridge methods [#​33212](spring-projects/spring-boot#33212) - Contribute missing resource hints for GraphQL schema files and GraphiQL HTML page [#​33208](spring-projects/spring-boot#33208) - Hints for ClientHttpRequestFactory should only be generated for matching methods [#​33203](spring-projects/spring-boot#33203) -...
ndwlocatieservices
added a commit
to ndwnu/nls-routing-map-matcher
that referenced
this pull request
Aug 21, 2024
…o v3 This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [nu.ndw.nls.geometry:nls-geometry](https://spring.io/projects/spring-boot) ([source](https://github.com/spring-projects/spring-boot)) | compile | major | `2.1.4` -> `3.0.0` | --- ### Release Notes <details> <summary>spring-projects/spring-boot (nu.ndw.nls.geometry:nls-geometry)</summary> ### [`v3.0.0`](https://github.com/spring-projects/spring-boot/releases/tag/v3.0.0) [Compare Source](spring-projects/spring-boot@v2.2.1.RELEASE...v3.0.0) See the [Release notes for 3.0](https://github.com/spring-projects/spring-boot/wiki/Spring-Boot-3.0-Release-Notes) for upgrade instructions and details of new features. #### ⭐ New Features - Provide a configuration property for the observation patterns of Spring Integration components [#​33099](spring-projects/spring-boot#33099) #### 🐞 Bug Fixes - io.micrometer.tracing.Tracer on the classpath breaks AOT processing for tests [#​33298](spring-projects/spring-boot#33298) - Tracer library HTTP instrumentation is auto-configured unnecessarily [#​33287](spring-projects/spring-boot#33287) - Auto-configuration ignores user-provided ObservationConventions [#​33285](spring-projects/spring-boot#33285) - `ScheduledBeanLazyInitializationExcludeFilter` is auto-configured even when annotation-based scheduled has not been enabled [#​33284](spring-projects/spring-boot#33284) - SpringBootContextLoader prints banner twice when using a `@ContextHierarchy` [#​33263](spring-projects/spring-boot#33263) - Properties migrator causes an application to fail to start if it tries to map a property whose metadata data entry contains an invalid configuration property name [#​33250](spring-projects/spring-boot#33250) - Wavefront MeterRegistryCustomizer is not applying application tags from application.properties [#​33244](spring-projects/spring-boot#33244) - Actuator responses no longer format timestamps as ISO-8601 [#​33236](spring-projects/spring-boot#33236) - Configuration property is not bound in a native image when property has get, set, and is methods [#​33232](spring-projects/spring-boot#33232) - Configuration property binding does not deal with bridge methods [#​33212](spring-projects/spring-boot#33212) - Contribute missing resource hints for GraphQL schema files and GraphiQL HTML page [#​33208](spring-projects/spring-boot#33208) - Hints for ClientHttpRequestFactory should only be generated for matching methods [#​33203](spring-projects/spring-boot#33203) -...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since it was decided that instead of using the tracing libraries (Brave, OTel) HTTP support, we will do something similar instrumentation time, we can remove the auto-configuration for these beans. (cc: @bclozel @marcingrzejszczak)
Slightly connected issue: #33228