Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add property to allow configuring Spring MVC trailing slash match #31327

Closed
wants to merge 1 commit into from
Closed

Add property to allow configuring Spring MVC trailing slash match #31327

wants to merge 1 commit into from

Conversation

vpavic
Copy link
Contributor

@vpavic vpavic commented Jun 10, 2022

See #31232.

@vpavic vpavic mentioned this pull request Jun 10, 2022
Closed
@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label Jun 10, 2022
@vpavic
Copy link
Contributor Author

vpavic commented Jun 10, 2022

I'd put this on hold until there are some conclusions around spring-projects/spring-framework#28552.

@philwebb philwebb added the status: on-hold We can't start working on this issue yet label Jun 10, 2022
@vpavic
Copy link
Contributor Author

vpavic commented Jun 21, 2022

With the outcome of spring-projects/spring-framework#28552, this PR probably makes sense only for 2.x where it could provide an easier option to align with the behavior (no trailing slash matching) that will become the default in Spring Framework 6.

@wilkinsona
Copy link
Member

It would have been nice to provide a migration path for this by flipping the default in Boot 2.x and providing a property to restore the old behaviour for those that really need it. Unfortunately, we've missed our window opportunity as we currently expect 2.7 to be the last minor in the 2.x line. As such, I think it makes sense to close this. Boot 3 users who want to re-enable the deprecated support for trailing slash matching can do so using a configurer bean.

@wilkinsona wilkinsona closed this Jun 21, 2022
@wilkinsona wilkinsona added status: declined A suggestion or change that we don't feel we should currently apply and removed status: on-hold We can't start working on this issue yet status: waiting-for-triage An issue we've not yet triaged labels Jun 21, 2022
@vpavic
Copy link
Contributor Author

vpavic commented Jun 21, 2022 •
edited
Loading

I thought I saw 2.8 references somewhere but if that's not going to happen, then yes, I agree this should be closed.

@vpavic vpavic deleted the trailing-slash-match-config branch June 21, 2022 16:02
@bclozel bclozel mentioned this pull request Jul 1, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
status: declined A suggestion or change that we don't feel we should currently apply
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@vpavic @wilkinsona @philwebb @spring-projects-issues