Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prepend additional keys to sanitize #30843

Closed
wants to merge 3 commits into from
Closed

Conversation

mrgrew
Copy link

@mrgrew mrgrew commented May 3, 2022

Per discussion in #30832, this change prepends additional keys to sanitize ahead of the defaults. This allows users to sanitize keys that would otherwise be handled by the defaults but still expose credentials.

@mrgrew mrgrew changed the title Prepend additional keys to sanitize handle keys that match one of the defaults Prepend additional keys to sanitize May 3, 2022
@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label May 3, 2022
@mrgrew
Copy link
Author

mrgrew commented Jun 17, 2022

I'm looking forward to some feedback on this PR - it's my first submission so I'm not sure how patient to be.

@wilkinsona
Copy link
Member

Thanks for your patience thus far, @mrgrew. As indicated by the labels on #30832, we'd like to look at this topic as a team so that we can decide what to do. We have a number of competing priorities at the moment but we will get to it as soon as we can.

@mbhave
Copy link
Contributor

mbhave commented Aug 23, 2022

Closing in favor of #32156. We've decide to move away from keys-to-sanitize because predicting the most secure default is tricky. We've instead decided to go for the most secure default which is to sanitize everything and allow that to be configured based on roles.

@mbhave mbhave closed this Aug 23, 2022
@mbhave mbhave added status: superseded An issue that has been superseded by another and removed status: waiting-for-triage An issue we've not yet triaged labels Aug 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: superseded An issue that has been superseded by another
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants