Auto-configure binding of Micrometer's JettyConnectionMetrics and JettySslHandshakeMetrics #26418
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tySslHandshakeMetrics Fixes gh-12090
onobc
commented
May 9, 2021
...ingframework/boot/actuate/autoconfigure/metrics/web/jetty/JettyMetricsAutoConfiguration.java
Show resolved
Hide resolved
onobc
commented
May 9, 2021
...in/java/org/springframework/boot/actuate/metrics/web/jetty/JettyConnectionMetricsBinder.java
Outdated
Show resolved
Hide resolved
onobc
commented
May 9, 2021
.../java/org/springframework/boot/actuate/metrics/web/jetty/JettySslHandshakeMetricsBinder.java
Outdated
Show resolved
Hide resolved
spring-projects-issues
added
the
status: waiting-for-triage
onobc
commented
May 9, 2021
...in/java/org/springframework/boot/actuate/metrics/web/jetty/JettyConnectionMetricsBinder.java
Show resolved
Hide resolved
|
Concourse CI had a hiccup when running the 2nd commit and I don't seem to have the creds to restart it. |
wilkinsona
added
type: enhancement
…ssl.enabled property
…icsBinder and JettySslHandshakeMetricsBinder
onobc
commented
May 14, 2021
...amework/boot/actuate/autoconfigure/metrics/web/jetty/JettyMetricsAutoConfigurationTests.java
Show resolved
Hide resolved
onobc
commented
May 14, 2021
...amework/boot/actuate/autoconfigure/metrics/web/jetty/JettyMetricsAutoConfigurationTests.java
Show resolved
Hide resolved
wilkinsona
pushed a commit
that referenced
this pull request
Jul 13, 2021
wilkinsona
added a commit
that referenced
this pull request
Jul 13, 2021
|
Thanks very much, @bono007. |
humaolin
pushed a commit
to humaolin/spring-boot
that referenced
this pull request
May 7, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This implements the suggestions here.
Fixes gh-12090