Having AspectJ and Micrometer on the classpath is not a strong enough signal to enable support for Micrometer observation annotations #39128
Assignees
Labels
status: noteworthy
A noteworthy issue to call out in the release notes
theme: observability
Issues related to observability
type: bug
A general bug
Milestone
Comments
bclozel
added
type: bug
bclozel
added
the
status: noteworthy
wilkinsona
changed the title
It seems like that might have been forgotten in the release notes? I like this change but have not perceived it as a noteworthy change in the release notes/blog. It does show up under "bugfixes". https://github.com/spring-projects/spring-boot/releases/tag/v3.2.2 I think the notes should be updated to highlight that change better? |
|
Thanks, @DRoppelt. Looks like we missed this during the release. I've added a Noteworthy Changes section to the top of the release notes for 3.2.2. |
|
hey @wilkinsona, just noticed that the release notes are incorrect. It says the property is |
|
Thanks @DarkAtra, I've edited the notes. |
|
I think that may be a mistake in the code as we have |
|
My mistake, I've created #39600 to fix that. |
ndwlocatieservices
added a commit
to ndwnu/nls-accessibility-map
that referenced
this issue
Jun 28, 2024
This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [nu.ndw.nls.springboot:openapi](https://spring.io/projects/spring-boot) ([source](https://github.com/spring-projects/spring-boot)) | build | patch | `3.2.6` -> `3.2.8` | | [nu.ndw.nls.springboot:oauth2-client-credentials](https://spring.io/projects/spring-boot) ([source](https://github.com/spring-projects/spring-boot)) | compile | patch | `3.2.6` -> `3.2.8` | | [nu.ndw.nls.springboot:test](https://spring.io/projects/spring-boot) ([source](https://github.com/spring-projects/spring-boot)) | test | patch | `3.2.6` -> `3.2.8` | | [nu.ndw.nls.springboot:security](https://spring.io/projects/spring-boot) ([source](https://github.com/spring-projects/spring-boot)) | compile | patch | `3.2.6` -> `3.2.8` | | [nu.ndw.nls.springboot:messaging](https://spring.io/projects/spring-boot) ([source](https://github.com/spring-projects/spring-boot)) | compile | patch | `3.2.6` -> `3.2.8` | | [nu.ndw.nls.springboot:datadog](https://spring.io/projects/spring-boot) ([source](https://github.com/spring-projects/spring-boot)) | compile | patch | `3.2.6` -> `3.2.8` | | [nu.ndw:nls-nwb-data-access-jooq](https://spring.io/projects/spring-boot) ([source](https://github.com/spring-projects/spring-boot)) | compile | patch | `4.2.5` -> `4.2.6` | | [org.springframework.boot:spring-boot-starter-parent](https://spring.io/projects/spring-boot) ([source](https://github.com/spring-projects/spring-boot)) | parent | patch | `3.2.1` -> `3.2.2` | --- ### Release Notes <details> <summary>spring-projects/spring-boot (org.springframework.boot:spring-boot-starter-parent)</summary> ### [`v3.2.2`](https://github.com/spring-projects/spring-boot/releases/tag/v3.2.2) [Compare Source](spring-projects/spring-boot@v3.2.1...v3.2.2) #### 🐞 Bug Fixes - SslBundle implementations do not provide useful toString() results [#​39167](spring-projects/spring-boot#39167) - JarEntry.getComment() returns incorrect result from NestedJarFile instances [#​39166](spring-projects/spring-boot#39166) - Mixing PEM and JKS certificate material in server.ssl properties does not work [#​39158](spring-projects/spring-boot#39158) - Having AspectJ and Micrometer on the classpath is not a strong enough signal to enable support for Micrometer observation annotations [#​39128](spring-projects/spring-boot#39128) - Actuator endpoints with no operations that use selectors are not accessible when mapped to / [#​39122](spring-projects/spring-boot#39122) - Spring Boot 3.2 app that uses WebFlux, Security, and Actuator may fail to start due to a missing authentication manager [#​39096](spring-projects/spring-boot#39096) - management.observations.http.server.requests.name no longer has any effect [...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
As of #37626, Spring Boot 3.2 auto-configures AspectJ handlers to support observation annotations like
@Timedand@CountedwithMetricsAspectsAutoConfiguration. Spring Boot 3.3 will expand that for tracing annotations inMicrometerTracingAutoConfiguration.Right now those auto-configurations are conditional on the presence of Micrometer and AspectJ, but we've found that those aspects are quite broadly applied and can significant startup time difference. While this is a fine feature to support, we should restrict a bit its application to ensure that it's only applied when developers choose to. The Aspectj dependency can come from many use cases and is not a good indicator for applications opting-in for this feature.
We should add a
management.observations.annotations.enabledconfiguration property and introduce it with a defaultfalsevalue. While this changes behavior, we're still early in the 3.2.x generation and this is a impact big enough that we're considering this a bug. We'll make this noteworthy in the release notes.The text was updated successfully, but these errors were encountered: