-
Notifications
You must be signed in to change notification settings - Fork 40.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Zip file closed exceptions can be thrown due to StaticResourceJars closing jars from cached connections #38766
Comments
Thanks for the sample. Note to aid our investigation, this can be reproduced without involving Docker:
|
@infoShare please don't open the same issue in two places. It's just going to waste someone's time. In this case I think it's very unlikely that Springdoc is causing the problem. I think springdoc/springdoc-openapi#2459 should be closed until an investigation here proves otherwise. |
@infoShare Thanks very much for the reproducer, I think I have fixed the underlying problem. It would be much appreciated if you could try the latest 3.2.1-SNAPSHOT to confirm. |
:: Spring Boot :: (v3.2.1-SNAPSHOT) Expected :"No static resource api/method." Issue still exists. |
I'm sorry, it looks like build 828 failed on our CI and the snapshot wasn't published. I'll post back here when we manage to actually get something published. |
A new snapshot has now been published to https://repo.spring.io/snapshot. It fixes the provided sample for me. Please double-check if you can, @infoShare. |
@philwebb @wilkinsona it is working correctly with the latest 3.2.1-SNAPSHOT version. Test is passing as well ! |
Great! Thanks for letting us know. |
Spring Boot version: 3.2.0 (Same on 3.2.1-SNAPSHOT)
Java: 21 (Amazon Corretto)
Zip file closed error is returned on calling not existing ("disabled") endpoint:
https://github.com/infoShare/code-examples/tree/main/spring-boot-404
Error exists only when running application from the jar file:
https://github.com/infoShare/code-examples/blob/main/spring-boot-404/src/test/java/infoshare/springboot404/controller/ApiControllerWithDockerTest.java
It is working correctly using Spring Boot Test:
https://github.com/infoShare/code-examples/blob/main/spring-boot-404/src/test/java/infoshare/springboot404/controller/ApiControllerWithProfileTest.java
Exception:
It looks like something related with using springdoc dependency:
Similar issue reported on the Springdoc project as this dependency is broking spring boot behavior:
springdoc/springdoc-openapi#2459
The text was updated successfully, but these errors were encountered: