-
Notifications
You must be signed in to change notification settings - Fork 40.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
FileNotFoundException is thrown eagerly from unused SSL bundles #38659
Comments
Regardless of your You could move the bundle definition from your I don't think there's a way to override the map which contains "server-ssl-bundle" with an empty one in the local profile (see #22894). Does this help? |
@mhalbritter thanks for the comment, the same setup works in version 3.1.3 |
Thanks, that's an important information. |
That's a side effect of 9b71ef4#diff-d76d8c6ae728a7f8c886725ec85f5597140e17ec3c7ce3b9a2ccd935b19c87e5R103. In 3.1.x, the loading of PEM stores (and I think JKS stores, too) was indeed lazy. In 3.2.x, this is no longer the case. But I would argue that your setup only worked by accident in 3.1.x. You specified a SSL bundle with two (non-existent) files, and it was the implementation leaking out that this worked. I'll flag this to get opinions from the team. |
@mhalbritter thanks for the quick reply, also please check this issue #2241 , where the spring team recommended to configure "server.ssl.enabled" property to conditionally disable SSL configuration based on profile. |
The problem has nothing to do with SSL on your webserver. It's failing because you defined an SslBundle and instructed it to load two files, which do not exist. This worked in 3.1.x as nothing called |
I completely understand @mhalbritter, but because of eager loading, why an existing functionality should break. This new change makes Is it possible to apply condition based bean loading based on this property. Please share us your thoughts. |
We might be able to change |
We're going to look at using |
Thanks, @philwebb and @mhalbritter for the fix and the support from the spring team. |
@azeem87 How did you deal with security auto-configuration? |
I still have that problem but with a reactive Webflux application. application.yml
application-local.yml
Logs
|
@weberpatrick please open a new issue with a minimal sample that reproduces the problem and we can take a look |
Though I have configured it below and disabled the SSL for the local profile, it is still looking for the certificate file and private key file
application.yml
application-local.yml as per #2241
The text was updated successfully, but these errors were encountered: