-
Notifications
You must be signed in to change notification settings - Fork 40.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Expose SpringValidatorAdapter contained in ValidatorAdapter via new SmartValidator method #37081
Labels
status: superseded
An issue that has been superseded by another
type: enhancement
A general enhancement
Comments
spring-projects-issues
added
the
status: waiting-for-triage
An issue we've not yet triaged
label
Aug 23, 2023
snicoll
added
type: enhancement
A general enhancement
and removed
status: waiting-for-triage
An issue we've not yet triaged
labels
Aug 23, 2023
zpavloudis
added a commit
to zpavloudis/spring-boot
that referenced
this issue
Aug 28, 2023
zpavloudis
added a commit
to zpavloudis/spring-boot
that referenced
this issue
Aug 30, 2023
zpavloudis
added a commit
to zpavloudis/spring-boot
that referenced
this issue
Aug 31, 2023
zpavloudis
added a commit
to zpavloudis/spring-boot
that referenced
this issue
Aug 31, 2023
… into expose-inner-validator-spring-projectsgh-37081
zpavloudis
added a commit
to zpavloudis/spring-boot
that referenced
this issue
Sep 4, 2023
zpavloudis
added a commit
to zpavloudis/spring-boot
that referenced
this issue
Sep 4, 2023
…ringValidatorAdapter" See spring-projectsgh-37081.
Closing in favor of #37119. |
wilkinsona
added
the
status: superseded
An issue that has been superseded by another
label
Sep 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
status: superseded
An issue that has been superseded by another
type: enhancement
A general enhancement
ValidatorAdapter
wrapsSpringValidatorAdapter
to expose it as aSmartValidator
, and not asjakarta.validation.Validator
to avoid competing with otherjakarta.validation.Validator
beans. This works fine since Sping MVC and WebFlux primarily need a SpringValidator
. However, for the built-in method validation in 6.1, Spring MVC and WebFlux need thejakarta.validation.Validator
and as a result the built-in method validation feature does not work currently with Boot autoconfig. See spring-projects/spring-framework#31082.To address this, we are adding a new
unwrap
method onSmartValidator
, and we'll needValidatorAdapter
to implement it to allow Spring MVC and WebFlux to unwrapValidatorAdapter
and access the validator instance it contains.The text was updated successfully, but these errors were encountered: