Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

management.metrics.export.signalfx properties are incomplete #36497

Closed
wilkinsona opened this issue Jul 21, 2023 · 2 comments
Closed

management.metrics.export.signalfx properties are incomplete #36497

wilkinsona opened this issue Jul 21, 2023 · 2 comments
Assignees
@wilkinsona
Labels
type: bug A general bug
Milestone
2.7.15

Comments

@wilkinsona
Copy link
Member

#33743 has revealed that the management.metrics.export.signalfx properties are incomplete. A property for pushCumulativeHistogram is missing.
@wilkinsona wilkinsona added the type: bug A general bug label Jul 21, 2023
@wilkinsona wilkinsona added this to the 2.7.x milestone Jul 21, 2023
@wilkinsona wilkinsona self-assigned this Jul 21, 2023
@wilkinsona
Copy link
Member Author

In 3.0.x, publishDeltaHistogram is also missing.

wilkinsona added a commit to wilkinsona/spring-boot that referenced this issue Jul 24, 2023
@wilkinsona
Add missing management.metrics.export.signalfx properties
cb5c506 
Closes spring-projectsgh-36497
@wilkinsona
Copy link
Member Author

Only one of delta or cumulative histograms may be published. If a SignalFxConfig implementation returns true from both publishCumulativeHistogram and publishDeltaHistogram, delta is used.

Rather than having two properties for this and relying on documentation for their mutual exclusivity, we could take advantage of this fact that we missed adding the properties and have an opportunity to consider both together by using a single property backed by an enum. In 2.7.x it would have two values (NONE, and CUMULATIVE). In 3.0.x we'd add DELTA to the values.

@wilkinsona wilkinsona mentioned this issue Jul 25, 2023
Closed
@wilkinsona wilkinsona modified the milestones: 2.7.x, 2.7.15 Jul 25, 2023
@Netyyyy Netyyyy mentioned this issue Aug 25, 2023
Closed
izeye added a commit to izeye/spring-boot that referenced this issue Sep 6, 2023
@izeye
Add default value metadata for management.metrics.export.signalfx.pub…
2598dba 
…lished-histogram-type

See spring-projectsgh-36497
@izeye izeye mentioned this issue Sep 6, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@wilkinsona wilkinsona

Labels
type: bug A general bug
Projects
None yet
Milestone
2.7.15
Development

No branches or pull requests
1 participant
@wilkinsona