Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make consistent use of Property for Gradle task configuration #32769

Closed
wilkinsona opened this issue Oct 18, 2022 · 1 comment
Closed

Make consistent use of Property for Gradle task configuration #32769

wilkinsona opened this issue Oct 18, 2022 · 1 comment
Assignees
@wilkinsona
Labels
type: enhancement A general enhancement
Milestone
3.0.0-RC1

Comments

@wilkinsona
Copy link
Member

This will help with #32768.
@wilkinsona wilkinsona added the type: enhancement A general enhancement label Oct 18, 2022
@wilkinsona wilkinsona added this to the 3.0.x milestone Oct 18, 2022
@wilkinsona wilkinsona self-assigned this Oct 18, 2022
@wilkinsona
Copy link
Member Author

wilkinsona commented Oct 18, 2022 •
edited
Loading

It will also result in breaking changes for Kotlin DSL users, but it would be better from a consistency perspective as we're almost completely Property-based elsewhere. I'm going to implement #32768 without this change and come back to it if there's time.

@wilkinsona wilkinsona changed the title Update BootBuildImage to use Property for its inputs Make consistent use of Property for Gradle task configuration Oct 19, 2022
@wilkinsona wilkinsona modified the milestones: 3.0.x, 3.0.0-RC1 Oct 19, 2022
scottfrederick added a commit that referenced this issue Oct 19, 2022
@scottfrederick
Use String instead of enum for Gradle task Property
8acf9af 
See gh-32769
scottfrederick added a commit that referenced this issue Oct 20, 2022
@scottfrederick
Allow Gradle task property to be set with String or enum value
b78b22b 
See gh-32769
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@wilkinsona wilkinsona

Labels
type: enhancement A general enhancement
Projects
None yet
Milestone
3.0.0-RC1
Development

No branches or pull requests
1 participant
@wilkinsona