-
Notifications
You must be signed in to change notification settings - Fork 40.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add java.vendor.version to JavaInfoContributor #28777
Comments
This sounds like a good idea to me. It sounds like it'll provide useful information in some situations and that it'll be harmless in others. |
What do you think about moving from this: "java": {
"vendor": "Eclipse Adoptium",
"version": "17.0.1",
"runtime": {
"name": "OpenJDK Runtime Environment",
"version": "17.0.1+12"
},
"vm": {
"name": "OpenJDK 64-Bit Server VM",
"vendor": "Eclipse Adoptium",
"version": "17.0.1+12"
}
} to this: "java": {
"version": "17.0.1",
"vendor": {
"name": "Eclipse Adoptium",
"version": "Temurin-17.0.1+12"
},
"runtime": {
"name": "OpenJDK Runtime Environment",
"version": "17.0.1+12"
},
"vm": {
"name": "OpenJDK 64-Bit Server VM",
"vendor": "Eclipse Adoptium",
"version": "17.0.1+12"
}
} This is a breaking change since the vendor field was a String before and now it is an object, everything else is the same. |
I think it's probably fine as tools consuming it should be able to try a few different JSON paths. We also have the option of bumping |
Closing in favor of PR #29090 |
There was a question about adding the
java.vendor.version
property toJavaInfoContributor
: #28136 (comment) originally raised by @dmengelt.I'm opening this issue to see/discuss what the community and the Boot Team thinks about adding this property. I ran some tests (see: #28136 (comment)) and there are a good amount of cases where the property is missing (was introduced in Java 10) or it does not make sense (see my comment).
It also seems that they wanted to remove the property but the community found it useful so they kept it (see: #28136 (comment)). Based on these I would say that the property makes sense mostly for the Zulu and the Corretto images (11 and 17, not 8) and might make sense for more distributions in the future.
The text was updated successfully, but these errors were encountered: