Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add java.vendor.version to JavaInfoContributor #28777

Closed
jonatan-ivanov opened this issue Nov 23, 2021 · 4 comments
Closed

Add java.vendor.version to JavaInfoContributor #28777

jonatan-ivanov opened this issue Nov 23, 2021 · 4 comments
Labels
status: superseded An issue that has been superseded by another type: enhancement A general enhancement

Comments

@jonatan-ivanov
Copy link
Member

jonatan-ivanov commented Nov 23, 2021

There was a question about adding the java.vendor.version property to JavaInfoContributor: #28136 (comment) originally raised by @dmengelt.

I'm opening this issue to see/discuss what the community and the Boot Team thinks about adding this property. I ran some tests (see: #28136 (comment)) and there are a good amount of cases where the property is missing (was introduced in Java 10) or it does not make sense (see my comment).

It also seems that they wanted to remove the property but the community found it useful so they kept it (see: #28136 (comment)). Based on these I would say that the property makes sense mostly for the Zulu and the Corretto images (11 and 17, not 8) and might make sense for more distributions in the future.

@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label Nov 23, 2021
@wilkinsona wilkinsona changed the title Adding java.vendor.version to JavaInfoContributor Add java.vendor.version to JavaInfoContributor Nov 23, 2021
@wilkinsona
Copy link
Member

This sounds like a good idea to me. It sounds like it'll provide useful information in some situations and that it'll be harmless in others.

@wilkinsona wilkinsona added type: enhancement A general enhancement and removed status: waiting-for-triage An issue we've not yet triaged labels Nov 29, 2021
@wilkinsona wilkinsona added this to the 2.7.x milestone Nov 29, 2021
@jonatan-ivanov
Copy link
Member Author

jonatan-ivanov commented Dec 15, 2021

What do you think about moving from this:

"java": {
    "vendor": "Eclipse Adoptium",
    "version": "17.0.1",
    "runtime": {
        "name": "OpenJDK Runtime Environment",
        "version": "17.0.1+12"
    },
    "vm": {
        "name": "OpenJDK 64-Bit Server VM",
        "vendor": "Eclipse Adoptium",
        "version": "17.0.1+12"
    }
}

to this:

"java": {
    "version": "17.0.1",
    "vendor": {
        "name": "Eclipse Adoptium",
        "version": "Temurin-17.0.1+12"
    },
    "runtime": {
        "name": "OpenJDK Runtime Environment",
        "version": "17.0.1+12"
    },
    "vm": {
        "name": "OpenJDK 64-Bit Server VM",
        "vendor": "Eclipse Adoptium",
        "version": "17.0.1+12"
    }
}

This is a breaking change since the vendor field was a String before and now it is an object, everything else is the same.

@philwebb
Copy link
Member

I think it's probably fine as tools consuming it should be able to try a few different JSON paths. We also have the option of bumping ActuatorMediaType if we really want to retain back compatibility.

jonatan-ivanov added a commit to jonatan-ivanov/spring-boot that referenced this issue Dec 16, 2021
@snicoll
Copy link
Member

snicoll commented Dec 17, 2021

Closing in favor of PR #29090

@snicoll snicoll closed this as completed Dec 17, 2021
@snicoll snicoll added the status: superseded An issue that has been superseded by another label Dec 17, 2021
@snicoll snicoll removed this from the 2.7.x milestone Dec 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: superseded An issue that has been superseded by another type: enhancement A general enhancement
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants
@snicoll @philwebb @wilkinsona @jonatan-ivanov @spring-projects-issues and others