Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

InvalidConfigDataPropertyException thrown when server processed ConfigData contains profiles #24890

Closed
philwebb opened this issue Jan 19, 2021 · 1 comment
Closed

InvalidConfigDataPropertyException thrown when server processed ConfigData contains profiles #24890

philwebb opened this issue Jan 19, 2021 · 1 comment
Labels
type: bug A general bug
Milestone
2.4.3

Comments

@philwebb
Copy link
Member

With Spring Cloud Config Server any spring.profiles.active and spring.profiles.include properties should only apply to the server-side. The config should ignore them. See #24876 and spring-cloud/spring-cloud-config#1788 for additional background.

Since we don't want to revert #24733, we need to find a way for Spring Cloud's ConfigServerConfigDataLocationResolver to indicate that a property source should not process any of it's profile properties. It looks like we might be able to do this by adding a ConfigData.IGNORE_PROFILES option that Spring Cloud can set.
@philwebb philwebb added the type: bug A general bug label Jan 19, 2021
@philwebb philwebb added this to the 2.4.x milestone Jan 19, 2021
This was referenced Jan 19, 2021
Closed
Closed
@philwebb
Copy link
Member Author

I've got a fix that should restore previous Spring Cloud Config Server behavior. There is one unfortunate issue that I can't fix until Spring Boot 2.5. If you have a spring.profiles.active property defined only on the server-side, there is no way to not have it apply to the client-side. This is due to AbstractEnvironment.doGetActiveProfiles().

I think we can live with this limitation for now, since the same thing happened with previous versions of Spring Cloud/Boot.

@philwebb philwebb mentioned this issue Jan 20, 2021
Closed
@philwebb philwebb modified the milestones: 2.4.x, 2.4.3 Jan 20, 2021
@philwebb philwebb mentioned this issue Jan 27, 2021
Closed
This was referenced Mar 11, 2021
Merged
Closed
Merged
Merged
Merged
Closed
Closed
Merged
Merged
@Haybu Haybu mentioned this issue Mar 15, 2021
Open
This was referenced Mar 16, 2021
Closed
Closed
Merged
Merged
Closed
Merged
Closed
Merged
philwebb added a commit that referenced this issue Apr 9, 2021
@philwebb
Add customer Application Environment subclasses
1d302f4 
Add custom `ApplicationEnvironment`, `ApplicationServletEnvironment`
and `ApplicationReactiveWebEnvironment` subclasses for use with
`SpringApplication`. The subclasses all disable the resolution of
active and default profiles using properties since this is handled
directly by the `ConfigDataEnvironmentPostProcessor`.

Closes gh-24892
See gh-24890
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
type: bug A general bug
Projects
None yet
Milestone
2.4.3
Development

No branches or pull requests
1 participant
@philwebb