Auto-configure binding of Micrometer's JettyServerThreadPoolMetrics

[matsumana]

Few months ago, I've added several Jetty's ThreadPool metrics in Micrometer.
ref: micrometer-metrics/micrometer#593

Could you add the following sources to Spring Boot 2.1?
I want to use them in Spring Boot 2.1

• https://github.com/micrometer-metrics/micrometer/blob/master/micrometer-spring-legacy/src/main/java/io/micrometer/spring/autoconfigure/web/jetty/JettyMetricsAutoConfiguration.java
• https://github.com/micrometer-metrics/micrometer/blob/master/micrometer-spring-legacy/src/main/java/io/micrometer/spring/autoconfigure/web/jetty/JettyMetricsPostProcessor.java

[wilkinsona]

Thanks for the suggestion. We can take a look at what's possible, but I don't think we can implement this in the same way as has been done in Micrometer. The biggest problem is that, if a user has customised Jetty's thread pool, the auto-configuration will overwrite that customisation.

[wilkinsona]

I asked a few questions on the Micrometer PR. We'll need some feedback on those to make progress on this one.

[spring-projects-issues]

If you would like us to look at this issue, please provide the requested information. If the information is not provided within the next 7 days this issue will be closed.

[matsumana]

I commented in micrometer-metrics/micrometer#593 (comment).
Could you please check it?

[wilkinsona]

Thanks. I've taken a look. Unfortunately, the problem with overwriting the user's thread pool customisation remains.

[wilkinsona]

FYI, @izeye. I think this approach is better than the one that we discussed on the Micrometer PR and the one that Boot was using for TomcatMetrics.

[izeye]

@wilkinsona Thanks for sharing! I'd like to align Spring Boot 1.5.x support with this but ApplicationStartedEvent has been introduced since 2.0.0. Is there any recommendation for Spring Boot 1.5.x?

[wilkinsona]

ApplicationReadyEvent is a reasonable substitute.

[izeye]

@wilkinsona Thanks for the quick feedback! I'll try with it.

[izeye]

@wilkinsona I created micrometer-metrics/micrometer#925 and micrometer-metrics/micrometer#926 to align Spring Boot 1.5.x support with this approach.

[matsumana]

Thank you so much!