Skip to content

Commit

Permalink
Add property 'management.wavefront.trace-derived-custom-tag-keys'
Browse files Browse the repository at this point in the history
Closes gh-34194
  • Loading branch information
mhalbritter committed Mar 1, 2023
1 parent 0fc4741 commit ecbc412
Show file tree
Hide file tree
Showing 2 changed files with 18 additions and 5 deletions.
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
/*
* Copyright 2012-2022 the original author or authors.
* Copyright 2012-2023 the original author or authors.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
Expand All @@ -16,8 +16,6 @@

package org.springframework.boot.actuate.autoconfigure.tracing.wavefront;

import java.util.Collections;

import brave.handler.SpanHandler;
import com.wavefront.sdk.common.WavefrontSender;
import com.wavefront.sdk.common.application.ApplicationTags;
Expand Down Expand Up @@ -65,7 +63,7 @@ public class WavefrontTracingAutoConfiguration {
WavefrontSpanHandler wavefrontSpanHandler(WavefrontProperties properties, WavefrontSender wavefrontSender,
SpanMetrics spanMetrics, ApplicationTags applicationTags) {
return new WavefrontSpanHandler(properties.getSender().getMaxQueueSize(), wavefrontSender, spanMetrics,
properties.getSourceOrDefault(), applicationTags, Collections.emptySet());
properties.getSourceOrDefault(), applicationTags, properties.getTraceDerivedCustomTagKeys());
}

@Configuration(proxyBeanMethods = false)
Expand Down
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
/*
* Copyright 2012-2022 the original author or authors.
* Copyright 2012-2023 the original author or authors.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
Expand All @@ -20,6 +20,8 @@
import java.net.URI;
import java.net.UnknownHostException;
import java.time.Duration;
import java.util.HashSet;
import java.util.Set;

import org.springframework.boot.actuate.autoconfigure.metrics.export.properties.PushRegistryProperties;
import org.springframework.boot.context.properties.ConfigurationProperties;
Expand Down Expand Up @@ -68,6 +70,11 @@ public class WavefrontProperties {
*/
private final Metrics metrics = new Metrics();

/**
* Customized span tags for RED metrics.
*/
private Set<String> traceDerivedCustomTagKeys = new HashSet<>();

public Application getApplication() {
return this.application;
}
Expand Down Expand Up @@ -150,6 +157,14 @@ private boolean usesProxy() {
return "proxy".equals(this.uri.getScheme());
}

public Set<String> getTraceDerivedCustomTagKeys() {
return this.traceDerivedCustomTagKeys;
}

public void setTraceDerivedCustomTagKeys(Set<String> traceDerivedCustomTagKeys) {
this.traceDerivedCustomTagKeys = traceDerivedCustomTagKeys;
}

public static class Application {

/**
Expand Down

0 comments on commit ecbc412

Please sign in to comment.