Merge pull request #37044 from joesteel2010

* pr/37044: Polish "Fix password property for Oracle container" Fix password property for Oracle container Closes gh-37044
spring-projects · Aug 22, 2023 · def05bf · def05bf
2 parents 6780b80 + 5a25c31
commit def05bf
Show file tree

Hide file tree

Showing 4 changed files with 13 additions and 9 deletions.
diff --git a/.../org/springframework/boot/docker/compose/service/connection/oracle/OracleEnvironment.java b/.../org/springframework/boot/docker/compose/service/connection/oracle/OracleEnvironment.java
@@ -42,12 +42,12 @@ class OracleEnvironment {
 
 	private String extractPassword(Map<String, String> env) {
 		if (env.containsKey("APP_USER")) {
-			String password = env.get("APP_PASSWORD");
+			String password = env.get("APP_USER_PASSWORD");
 			Assert.state(StringUtils.hasLength(password), "No Oracle app password found");
 			return password;
 		}
 		Assert.state(!env.containsKey("ORACLE_RANDOM_PASSWORD"),
-				"ORACLE_RANDOM_PASSWORD is not supported without APP_USER and APP_PASSWORD");
+				"ORACLE_RANDOM_PASSWORD is not supported without APP_USER and APP_USER_PASSWORD");
 		String password = env.get("ORACLE_PASSWORD");
 		Assert.state(StringUtils.hasLength(password), "No Oracle password found");
 		return password;

diff --git a/...springframework/boot/docker/compose/service/connection/oracle/OracleEnvironmentTests.java b/...springframework/boot/docker/compose/service/connection/oracle/OracleEnvironmentTests.java
@@ -34,7 +34,8 @@ class OracleEnvironmentTests {
 
 	@Test
 	void getUsernameWhenHasAppUser() {
-		OracleEnvironment environment = new OracleEnvironment(Map.of("APP_USER", "alice", "APP_PASSWORD", "secret"));
+		OracleEnvironment environment = new OracleEnvironment(
+				Map.of("APP_USER", "alice", "APP_USER_PASSWORD", "secret"));
 		assertThat(environment.getUsername()).isEqualTo("alice");
 	}
 
@@ -46,7 +47,8 @@ void getUsernameWhenHasNoAppUser() {
 
 	@Test
 	void getPasswordWhenHasAppPassword() {
-		OracleEnvironment environment = new OracleEnvironment(Map.of("APP_USER", "alice", "APP_PASSWORD", "secret"));
+		OracleEnvironment environment = new OracleEnvironment(
+				Map.of("APP_USER", "alice", "APP_USER_PASSWORD", "secret"));
 		assertThat(environment.getPassword()).isEqualTo("secret");
 	}
 
@@ -59,14 +61,14 @@ void getPasswordWhenHasOraclePassword() {
 	@Test
 	void createWhenRandomPasswordAndAppPasswordDoesNotThrow() {
 		assertThatNoException().isThrownBy(() -> new OracleEnvironment(
-				Map.of("APP_USER", "alice", "APP_PASSWORD", "secret", "ORACLE_RANDOM_PASSWORD", "true")));
+				Map.of("APP_USER", "alice", "APP_USER_PASSWORD", "secret", "ORACLE_RANDOM_PASSWORD", "true")));
 	}
 
 	@Test
 	void createWhenRandomPasswordThrowsException() {
 		assertThatIllegalStateException()
 			.isThrownBy(() -> new OracleEnvironment(Map.of("ORACLE_RANDOM_PASSWORD", "true")))
-			.withMessage("ORACLE_RANDOM_PASSWORD is not supported without APP_USER and APP_PASSWORD");
+			.withMessage("ORACLE_RANDOM_PASSWORD is not supported without APP_USER and APP_USER_PASSWORD");
 	}
 
 	@Test
@@ -78,7 +80,7 @@ void createWhenAppUserAndNoAppPasswordThrowsException() {
 	@Test
 	void createWhenAppUserAndEmptyAppPasswordThrowsException() {
 		assertThatIllegalStateException()
-			.isThrownBy(() -> new OracleEnvironment(Map.of("APP_USER", "alice", "APP_PASSWORD", "")))
+			.isThrownBy(() -> new OracleEnvironment(Map.of("APP_USER", "alice", "APP_USER_PASSWORD", "")))
 			.withMessage("No Oracle app password found");
 	}
 

diff --git a/...ce/connection/oracle/OracleJdbcDockerComposeConnectionDetailsFactoryIntegrationTests.java b/...ce/connection/oracle/OracleJdbcDockerComposeConnectionDetailsFactoryIntegrationTests.java
@@ -51,8 +51,8 @@ class OracleJdbcDockerComposeConnectionDetailsFactoryIntegrationTests extends Ab
 	@SuppressWarnings("unchecked")
 	void runCreatesConnectionDetailsThatCanBeUsedToAccessDatabase() throws Exception {
 		JdbcConnectionDetails connectionDetails = run(JdbcConnectionDetails.class);
-		assertThat(connectionDetails.getUsername()).isEqualTo("system");
-		assertThat(connectionDetails.getPassword()).isEqualTo("secret");
+		assertThat(connectionDetails.getUsername()).isEqualTo("app_user");
+		assertThat(connectionDetails.getPassword()).isEqualTo("app_user_secret");
 		assertThat(connectionDetails.getJdbcUrl()).startsWith("jdbc:oracle:thin:@").endsWith("/xepdb1");
 		SimpleDriverDataSource dataSource = new SimpleDriverDataSource();
 		dataSource.setUrl(connectionDetails.getJdbcUrl());

diff --git a/...ces/org/springframework/boot/docker/compose/service/connection/oracle/oracle-compose.yaml b/...ces/org/springframework/boot/docker/compose/service/connection/oracle/oracle-compose.yaml
@@ -4,6 +4,8 @@ services:
     ports:
       - '1521'
     environment:
+      - 'APP_USER=app_user'
+      - 'APP_USER_PASSWORD=app_user_secret'
       - 'ORACLE_PASSWORD=secret'
     healthcheck:
       test: ["CMD-SHELL", "healthcheck.sh"]