-
Notifications
You must be signed in to change notification settings - Fork 40.9k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Align NettyProperties with Netty's defaults
Prior to this commit, `NettyProperties` would use `DISABLED` as the default level for leak detection in Netty. This is not the default value enforced by Netty, which is `SIMPLE`. This commit changes the default configuration property value and ensures that both stay in sync. Fixes gh-27046
- Loading branch information
Showing
2 changed files
with
39 additions
and
1 deletion.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
38 changes: 38 additions & 0 deletions
38
...gure/src/test/java/org/springframework/boot/autoconfigure/netty/NettyPropertiesTests.java
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,38 @@ | ||
/* | ||
* Copyright 2012-2021 the original author or authors. | ||
* | ||
* Licensed under the Apache License, Version 2.0 (the "License"); | ||
* you may not use this file except in compliance with the License. | ||
* You may obtain a copy of the License at | ||
* | ||
* https://www.apache.org/licenses/LICENSE-2.0 | ||
* | ||
* Unless required by applicable law or agreed to in writing, software | ||
* distributed under the License is distributed on an "AS IS" BASIS, | ||
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
* See the License for the specific language governing permissions and | ||
* limitations under the License. | ||
*/ | ||
|
||
package org.springframework.boot.autoconfigure.netty; | ||
|
||
import io.netty.util.ResourceLeakDetector; | ||
import org.junit.jupiter.api.Test; | ||
|
||
import static org.assertj.core.api.Assertions.assertThat; | ||
|
||
/** | ||
* Tests for {@link NettyProperties} | ||
* | ||
* @author Brian Clozel | ||
*/ | ||
class NettyPropertiesTests { | ||
|
||
@Test | ||
void defaultValueShouldMatchNettys() { | ||
NettyProperties properties = new NettyProperties(); | ||
assertThat(ResourceLeakDetector.Level.valueOf(properties.getLeakDetection().name())) | ||
.isEqualTo(ResourceLeakDetector.getLevel()); | ||
} | ||
|
||
} |