Skip to content

Commit

Permalink
Merge branch '2.7.x' into 3.0.x
Browse files Browse the repository at this point in the history
Closes gh-38091
  • Loading branch information
wilkinsona committed Oct 27, 2023
2 parents dc31ee1 + e21fda2 commit 66ae086
Show file tree
Hide file tree
Showing 3 changed files with 12 additions and 12 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -46,15 +46,15 @@ class ArchitectureCheckTests {
void whenPackagesAreTangledTaskFailsAndWritesAReport() throws Exception {
prepareTask("tangled", (architectureCheck) -> {
assertThatExceptionOfType(GradleException.class).isThrownBy(architectureCheck::checkArchitecture);
assertThat(failureReport(architectureCheck).length()).isGreaterThan(0);
assertThat(failureReport(architectureCheck)).isNotEmpty();
});
}

@Test
void whenPackagesAreNotTangledTaskSucceedsAndWritesAnEmptyReport() throws Exception {
prepareTask("untangled", (architectureCheck) -> {
architectureCheck.checkArchitecture();
assertThat(failureReport(architectureCheck).length()).isZero();
assertThat(failureReport(architectureCheck)).isEmpty();
});
}

Expand All @@ -66,15 +66,15 @@ File failureReport(ArchitectureCheck architectureCheck) {
void whenBeanPostProcessorBeanMethodIsNotStaticTaskFailsAndWritesAReport() throws Exception {
prepareTask("bpp/nonstatic", (architectureCheck) -> {
assertThatExceptionOfType(GradleException.class).isThrownBy(architectureCheck::checkArchitecture);
assertThat(failureReport(architectureCheck).length()).isGreaterThan(0);
assertThat(failureReport(architectureCheck)).isNotEmpty();
});
}

@Test
void whenBeanPostProcessorBeanMethodIsStaticAndHasUnsafeParametersTaskFailsAndWritesAReport() throws Exception {
prepareTask("bpp/unsafeparameters", (architectureCheck) -> {
assertThatExceptionOfType(GradleException.class).isThrownBy(architectureCheck::checkArchitecture);
assertThat(failureReport(architectureCheck).length()).isGreaterThan(0);
assertThat(failureReport(architectureCheck)).isNotEmpty();
});
}

Expand All @@ -83,7 +83,7 @@ void whenBeanPostProcessorBeanMethodIsStaticAndHasSafeParametersTaskSucceedsAndW
throws Exception {
prepareTask("bpp/safeparameters", (architectureCheck) -> {
architectureCheck.checkArchitecture();
assertThat(failureReport(architectureCheck).length()).isZero();
assertThat(failureReport(architectureCheck)).isEmpty();
});
}

Expand All @@ -92,23 +92,23 @@ void whenBeanPostProcessorBeanMethodIsStaticAndHasNoParametersTaskSucceedsAndWri
throws Exception {
prepareTask("bpp/noparameters", (architectureCheck) -> {
architectureCheck.checkArchitecture();
assertThat(failureReport(architectureCheck).length()).isZero();
assertThat(failureReport(architectureCheck)).isEmpty();
});
}

@Test
void whenBeanFactoryPostProcessorBeanMethodIsNotStaticTaskFailsAndWritesAReport() throws Exception {
prepareTask("bfpp/nonstatic", (architectureCheck) -> {
assertThatExceptionOfType(GradleException.class).isThrownBy(architectureCheck::checkArchitecture);
assertThat(failureReport(architectureCheck).length()).isGreaterThan(0);
assertThat(failureReport(architectureCheck)).isNotEmpty();
});
}

@Test
void whenBeanFactoryPostProcessorBeanMethodIsStaticAndHasParametersTaskFailsAndWritesAReport() throws Exception {
prepareTask("bfpp/parameters", (architectureCheck) -> {
assertThatExceptionOfType(GradleException.class).isThrownBy(architectureCheck::checkArchitecture);
assertThat(failureReport(architectureCheck).length()).isGreaterThan(0);
assertThat(failureReport(architectureCheck)).isNotEmpty();
});
}

Expand All @@ -117,7 +117,7 @@ void whenBeanFactoryPostProcessorBeanMethodIsStaticAndHasNoParametersTaskSucceed
throws Exception {
prepareTask("bfpp/noparameters", (architectureCheck) -> {
architectureCheck.checkArchitecture();
assertThat(failureReport(architectureCheck).length()).isZero();
assertThat(failureReport(architectureCheck)).isEmpty();
});
}

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@
*
* @author Andy Wilkinson
*/
public class ReleaseScheduleTests {
class ReleaseScheduleTests {

private final RestTemplate rest = new RestTemplate();

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,7 @@
*
* @author Andy Wilkinson
*/
public class DependencyVersionUpgradeTests {
class DependencyVersionUpgradeTests {

@ParameterizedTest
@ArtifactVersion(current = "1.2.3", candidate = "1.2.3")
Expand Down Expand Up @@ -244,7 +244,7 @@ void isUpgradeWhenReleaseTrainToSnapshotAndMovingToSnapshotsShouldReturnTrue(Dep
static class InputProvider implements ArgumentsProvider {

@Override
public Stream<? extends Arguments> provideArguments(ExtensionContext context) throws Exception {
public Stream<? extends Arguments> provideArguments(ExtensionContext context) {
Method testMethod = context.getRequiredTestMethod();
Stream<Arguments> artifactVersions = artifactVersions(testMethod)
.map((artifactVersion) -> Arguments.of(VersionType.ARTIFACT_VERSION.parse(artifactVersion.current()),
Expand Down

0 comments on commit 66ae086

Please sign in to comment.