Skip to content

Commit

Permalink
Merge branch '3.0.x' into 3.1.x
Browse files Browse the repository at this point in the history
Closes gh-36526
  • Loading branch information
wilkinsona committed Jul 24, 2023
2 parents a38726f + 2db45e9 commit 54323d1
Show file tree
Hide file tree
Showing 4 changed files with 60 additions and 3 deletions.
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
/*
* Copyright 2012-2022 the original author or authors.
* Copyright 2012-2023 the original author or authors.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
Expand Down Expand Up @@ -78,6 +78,21 @@ public class AtlasProperties {
*/
private boolean lwcEnabled;

/**
* Step size (reporting frequency) to use for streaming to Atlas LWC. This is the
* highest supported resolution for getting an on-demand stream of the data. It must
* be less than or equal to management.metrics.export.atlas.step and
* management.metrics.export.atlas.step should be an even multiple of this value.
*/
private Duration lwcStep = Duration.ofSeconds(5);

/**
* Whether expressions with the same step size as Atlas publishing should be ignored
* for streaming. Used for cases where data being published to Atlas is also sent into
* streaming from the backend.
*/
private boolean lwcIgnorePublishStep = true;

/**
* Frequency for refreshing config settings from the LWC service.
*/
Expand Down Expand Up @@ -170,6 +185,22 @@ public void setLwcEnabled(boolean lwcEnabled) {
this.lwcEnabled = lwcEnabled;
}

public Duration getLwcStep() {
return this.lwcStep;
}

public void setLwcStep(Duration lwcStep) {
this.lwcStep = lwcStep;
}

public boolean isLwcIgnorePublishStep() {
return this.lwcIgnorePublishStep;
}

public void setLwcIgnorePublishStep(boolean lwcIgnorePublishStep) {
this.lwcIgnorePublishStep = lwcIgnorePublishStep;
}

public Duration getConfigRefreshFrequency() {
return this.configRefreshFrequency;
}
Expand Down
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
/*
* Copyright 2012-2019 the original author or authors.
* Copyright 2012-2023 the original author or authors.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
Expand Down Expand Up @@ -84,6 +84,16 @@ public boolean lwcEnabled() {
return get(AtlasProperties::isLwcEnabled, AtlasConfig.super::lwcEnabled);
}

@Override
public Duration lwcStep() {
return get(AtlasProperties::getLwcStep, AtlasConfig.super::lwcStep);
}

@Override
public boolean lwcIgnorePublishStep() {
return get(AtlasProperties::isLwcIgnorePublishStep, AtlasConfig.super::lwcIgnorePublishStep);
}

@Override
public Duration configRefreshFrequency() {
return get(AtlasProperties::getConfigRefreshFrequency, AtlasConfig.super::configRefreshFrequency);
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -116,4 +116,18 @@ void whenPropertiesEvalUriIsSetAdapterEvalUriReturnsIt() {
.isEqualTo("https://atlas.example.com/evaluate");
}

@Test
void whenPropertiesLwcStepIsSetAdapterLwcStepReturnsIt() {
AtlasProperties properties = new AtlasProperties();
properties.setLwcStep(Duration.ofSeconds(30));
assertThat(new AtlasPropertiesConfigAdapter(properties).lwcStep()).isEqualTo(Duration.ofSeconds(30));
}

@Test
void whenPropertiesLwcIgnorePublishStepIsSetAdapterLwcIgnorePublishStepReturnsIt() {
AtlasProperties properties = new AtlasProperties();
properties.setLwcIgnorePublishStep(false);
assertThat(new AtlasPropertiesConfigAdapter(properties).lwcIgnorePublishStep()).isFalse();
}

}
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
/*
* Copyright 2012-2019 the original author or authors.
* Copyright 2012-2023 the original author or authors.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
Expand Down Expand Up @@ -41,6 +41,8 @@ void defaultValuesAreConsistent() {
assertThat(properties.getUri()).isEqualTo(config.uri());
assertThat(properties.getMeterTimeToLive()).isEqualTo(config.meterTTL());
assertThat(properties.isLwcEnabled()).isEqualTo(config.lwcEnabled());
assertThat(properties.getLwcStep()).isEqualTo(config.lwcStep());
assertThat(properties.isLwcIgnorePublishStep()).isEqualTo(config.lwcIgnorePublishStep());
assertThat(properties.getConfigRefreshFrequency()).isEqualTo(config.configRefreshFrequency());
assertThat(properties.getConfigTimeToLive()).isEqualTo(config.configTTL());
assertThat(properties.getConfigUri()).isEqualTo(config.configUri());
Expand Down

0 comments on commit 54323d1

Please sign in to comment.