Add test for result streaming with data-jpa #171
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The mentioned PR has been merged to main and backported to 3.0.x. |
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
|
The new test will fail until Boot's switched to Spring Data snapshots again (in ~2 weeks time). I'm inclined to either wait for that to happen or to temporarily override the version of Spring Data that's used. WDYT, @christophstrobl? |
|
2 more weeks should be fine, we'd still have enough time to revisit the issue if something (unexpectedly) breaks. Same for #161 . |
wilkinsona
changed the title
|
Boot already picked up the Spring Data BOM for 2022.0.5 (spring-projects/spring-boot#34903). Please let me know if there's anything I can help with. |
wilkinsona
added
type: enhancement
wilkinsona
pushed a commit
that referenced
this pull request
Apr 18, 2023
|
Thanks for the nudge, Christoph. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See: spring-projects/spring-data-jpa#2848
The test will fail until spring-projects/spring-data-jpa#2880 is merged to main and back ported to the 3.0.x maintenance branch.