Upgrade Milvus java sdk to 2.5.4 #2313
Open
+37
−34
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
ilayaperumalg
commented
Feb 25, 2025
ilayaperumalg
commented
- Upgrade Milvus java sdk to 2.5.4
- Remove use of fastjson
- Use com.google.gson.JsonObject as Milvus SDK replaces fastjson with gson
- Change SearchResult RowRecord similarity metric name to score
- Milvus SDK 2.5.4 uses "score" instead of "distance"
- Upgrade Milvus java sdk to 2.5.4
- Remove use of fastjson
- Use com.google.gson.JsonObject as Milvus SDK replaces fastjson with gson
- Change SearchResult RowRecord similarity metric name to score
- Milvus SDK 2.5.4 uses "score" instead of "distance"
Signed-off-by: Ilayaperumal Gopinathan <[email protected]>
ilayaperumalg
commented
Feb 25, 2025
| @@ -110,7 +110,8 @@ protected void deleteById() { | |||
| assertThat(results.get(0).getId()).isEqualTo(documents.get(2).getId()); | |||
| Map<String, Object> metadata = results.get(0).getMetadata(); | |||
| assertThat(normalizeValue(metadata.get("country"))).isEqualTo("BG"); | |||
| assertThat(normalizeValue(metadata.get("year"))).isEqualTo("2023"); | |||
| // the values are converted into Double | |||
| assertThat(normalizeValue(metadata.get("year"))).isEqualTo("2023.0"); | |||
There was a problem hiding this comment.
The metadata for number values get converted into double to avoid data loss. But, there can be a better way to handle.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.