Skip to content
This repository has been archived by the owner on Aug 8, 2024. It is now read-only.

Feature: Remove value from cache #194

Merged
merged 4 commits into from
Jul 8, 2021
Merged

Feature: Remove value from cache #194

merged 4 commits into from
Jul 8, 2021

Conversation

ivanlisovyi
Copy link
Contributor

Context

This PR implements a feature request from the issue #193. We indeed don't provide a way to remove a value for specific key from a cache and it kinda does make sense to have this functionality.

Changes

  • Add remove(_ key: Key) method to CacheLevel protocol
  • Implement the newly added method in the cache levels
  • Add unit tests for the newly added method
  • Upgrade Quick & Nimble to 4.0.0 and 9.2.0

@ivanlisovyi ivanlisovyi requested review from toupper and hr147 July 8, 2021 13:47
@ivanlisovyi ivanlisovyi mentioned this pull request Jul 8, 2021
Closed
@sonarqubecloud
Copy link

sonarqubecloud bot commented Jul 8, 2021

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

No Coverage information No Coverage information
0.0% 0.0% Duplication

@ivanlisovyi ivanlisovyi merged commit 497a318 into master Jul 8, 2021
@ivanlisovyi ivanlisovyi deleted the feature/remove-object-from-cache branch July 8, 2021 15:55
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@hr147 hr147 hr147 approved these changes

@toupper toupper toupper approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ivanlisovyi @toupper @hr147