Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Setup unit test on frontend #215

Closed
wants to merge 4 commits into from
Closed

Setup unit test on frontend #215

wants to merge 4 commits into from

Conversation

oodamien
Copy link
Contributor

@oodamien oodamien commented Aug 7, 2019

Add jest Test
Review build task (add tests)
CI: Resolve dep. warnings

@oodamien oodamien changed the title Setup frontend unit test on frontend Setup unit test on frontend Aug 7, 2019
@snicoll
Copy link
Contributor

snicoll commented Aug 9, 2019

@oodamien as the PR build indicates there is a large amount of errors in the log. I don't know if that's related to that PR or not but it looks like it is. Can you please review?

@snicoll snicoll added the status: waiting-for-feedback We need additional information before we can continue label Aug 9, 2019
@oodamien
Copy link
Contributor Author

@snicoll
The yarn output is shown on ERROR (when building with maven).
eirslett/frontend-maven-plugin#584
Note: when a test JS failed, the build is on error (exit 1).

@snicoll
Copy link
Contributor

snicoll commented Aug 22, 2019

This module could help with the error log: jestjs/jest#5064 (comment)

snicoll pushed a commit that referenced this pull request Aug 23, 2019
@snicoll snicoll closed this in 025fac8 Aug 23, 2019
@snicoll snicoll added type: task and removed status: waiting-for-feedback We need additional information before we can continue labels Aug 23, 2019
@snicoll snicoll self-assigned this Aug 23, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants