Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Okta compatibility range to include 3.1.0-M2 #1158

Conversation

arvindkrishnakumar-okta
Copy link
Contributor

@arvindkrishnakumar-okta arvindkrishnakumar-okta commented Apr 21, 2023

@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label Apr 21, 2023
@snicoll
Copy link
Contributor

snicoll commented Apr 21, 2023

@arvindkrishnakumar-okta that's not how we proceed with this. The current range excludes the whole 3.1.x range (i.e. it's 3.1.0.M1 excluded).

We can of course open the starter for Spring Boot 3.1 but it would be nice to have some sort of verification that things are working with Spring Boot 3.1 and, in particular, Spring Security 6.1. Having a CI build that runs on 3.1 would be ideal but we can also be pragmatic if you have tried something a bit more manual. Thanks.

@snicoll snicoll added the status: waiting-for-feedback We need additional information before we can continue label Apr 21, 2023
@arvindkrishnakumar-okta
Copy link
Contributor Author

Thanks @snicoll, I'll add some verification on the Okta starter side.

@arvindkrishnakumar-okta arvindkrishnakumar-okta deleted the patch-14 branch April 21, 2023 16:16
@snicoll snicoll removed status: waiting-for-feedback We need additional information before we can continue status: waiting-for-triage An issue we've not yet triaged labels Apr 22, 2023
@mraible
Copy link

mraible commented Apr 28, 2023

I've verified the Okta Spring Boot starter works with 3.1.0-RC1. I found an issue with CSRF when testing it. spring-projects/spring-security#13075

Now, for things work with Spring Boot 3.1.0-RC, I have to upgrade Spring Security.

<properties>
    <java.version>17</java.version>
    <spring-security.version>6.1.0-SNAPSHOT</spring-security.version>
</properties>

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants