Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Mariadb needs to be treated as a independent db type. #833

Closed
cppwfs opened this issue Feb 17, 2022 · 2 comments · Fixed by #872
Closed

Mariadb needs to be treated as a independent db type. #833

cppwfs opened this issue Feb 17, 2022 · 2 comments · Fixed by #872
Milestone
3.0.0-RC2

Comments

@cppwfs
Copy link
Collaborator

cppwfs commented Feb 17, 2022

Currently Task treats mariadb as a version of MySql. Task needs to treat mariadb as its own type.
@tyler2cr tyler2cr mentioned this issue Apr 14, 2022
Closed
ben-enfuse-io added a commit to enfuse/spring-cloud-task that referenced this issue Apr 18, 2022
@ben-enfuse-io
Treat MariaDB as an independent database type. Resolves spring-cloud#833
d9510ad
@ben-enfuse-io ben-enfuse-io mentioned this issue Apr 18, 2022
Closed
@fmbenhassine
Copy link
Collaborator

We have the same request for Spring Batch here: spring-projects/spring-batch#3891.

While SF was updated to treat MariaDB as an independent database, I believe Batch and Task need a dedicated incrementer as described here: spring-projects/spring-framework#28355 (comment), to be able to implement this feature correctly.

cppwfs added a commit to cppwfs/spring-cloud-task that referenced this issue Oct 25, 2022
@cppwfs
Add support for mariadb
799836d 
resolves spring-cloud#833

PagingProvider and integration tests added
@cppwfs cppwfs added this to the 3.0.0-RC2 milestone Oct 28, 2022
cppwfs added a commit to cppwfs/spring-cloud-task that referenced this issue Oct 28, 2022
@cppwfs
Add support for mariadb
4759861 
resolves spring-cloud#833

PagingProvider and integration tests added
@cppwfs cppwfs mentioned this issue Oct 28, 2022
Merged
@cppwfs cppwfs closed this as completed in f857359 Oct 28, 2022
@cppwfs
Copy link
Collaborator Author

cppwfs commented Oct 28, 2022

a special thanks to @ben-enfuse-io for his efforts on this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
3.0.0-RC2
Development

Successfully merging a pull request may close this issue.

Add support for mariadb cppwfs/spring-cloud-task
2 participants
@cppwfs @fmbenhassine