Support rx java #243
Merged
Support rx java #243
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1) Because RxJavaPlugins is protected does not expose `reset()`, a wrapper had to be introduced. More details can be found here: ReactiveX/RxJava#2297 2) The implementation (and testing) strategy was followed per HystrixConcurrencyStrategy implementation. 3) Adding integration test cases
(If users need one they can add it themselves) Fixes spring-cloudgh-239
This updates to the latest release. Beyond bug fixes, there are some notable changes: * storage: writes are now via AsyncSpanConsumer * storage: added elasticsearch * zipkin-ui: constrains start time to look for traces * zipkin-ui: assets set cache headers, increasing responsiveness * core: debug logging available for zipkin.internal.DependencyLinker
The retryable case was already covered and tested but if the exception is not retryable, we need to rethrow and clean up the thread state. Fixes spring-cloudgh-240
|
One comment I'd like to make here is when I run the integration test case I wrote by itself: |
…-cloud-sleuth into marcingrzejszczak-rx_java
shivangshah
pushed a commit
to shivangshah/spring-cloud-netflix
that referenced
this pull request
May 5, 2016
This update on RxJava version is in regards to the PR that got merged [`here`](ReactiveX/RxJava#3820) for making RxJavaPlugins' `reset` method to be public. We have to work this around in Spring Sleuth. Details on the implementation can be found [`here`] (spring-cloud/spring-cloud-sleuth#243). 1.1.5
spencergibb
pushed a commit
to spring-cloud/spring-cloud-netflix
that referenced
this pull request
May 6, 2016
This update on RxJava version is in regards to the PR that got merged [`here`](ReactiveX/RxJava#3820) for making RxJavaPlugins' `reset` method to be public. We have to work this around in Spring Sleuth. Details on the implementation can be found [`here`] (spring-cloud/spring-cloud-sleuth#243). 1.1.5
spencergibb
added a commit
to spring-cloud/spring-cloud-netflix
that referenced
this pull request
May 6, 2016
* pull1007: Updating RxJava version to 1.1.5 This update on RxJava version is in regards to the PR that got merged [`here`](ReactiveX/RxJava#3820) for making RxJavaPlugins' `reset` method to be public. We have to work this around in Spring Sleuth. Details on the implementation can be found [`here`] (spring-cloud/spring-cloud-sleuth#243).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding support for
RxJava: #235We're registering a custom https://github.com/ReactiveX/RxJava/wiki/Plugins#rxjavaschedulershook [
RxJavaSchedulersHook] that wraps allAction0instances into their Sleuth representative - theTraceAction. The hook either starts or continues a span depending on the fact whether tracing was already going on before the Action was scheduled. To disable the custom RxJavaSchedulersHook set thespring.sleuth.rxjava.schedulers.hook.enabledtofalse.reset(), a wrapper had to be introduced. More details can be found here: Make RxJavaPlugins.reset() public ReactiveX/RxJava#2297