Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create custom Spring scopes for Span (and Trace if possible) #144

Closed
rLitto opened this issue Feb 5, 2016 · 4 comments
Closed

Create custom Spring scopes for Span (and Trace if possible) #144

rLitto opened this issue Feb 5, 2016 · 4 comments

Comments

@rLitto
Copy link

rLitto commented Feb 5, 2016

Working on a similar problem I encountered the need to set and have access to some variables that should live only for the Span of an operation.
Eg: storing some header information that arrives from a jms message, without having access to a Session or Request scope.

I resolved to use a (Named)InheritableThreadLocal element inside a component, but this could be solved by adding a custom scope, that if a request comes from http overlaps the Request scope, but is available even if a request comes from a jms (or other) calls:

Custom scope for JMS

@dsyer dsyer added the icebox label Feb 15, 2016
@marcingrzejszczak
Copy link
Contributor

After #711 , I think that this will now be solved via ExtraFieldPropagation.set and ExtraFieldPropagation.get. If the fields are not set in the whitelist of headers then they will not be propagated. WDYT @adriancole ?

@codefromthecrypt
Copy link
Contributor

codefromthecrypt commented Jan 21, 2018 via email

@codefromthecrypt
Copy link
Contributor

huge redo of the openzipkin/brave#577 description complete

@marcingrzejszczak
Copy link
Contributor

Anyways, I guess this problem will be moved to Brave. I'll close this one in favour of openzipkin/brave#577

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants