-
Notifications
You must be signed in to change notification settings - Fork 783
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create custom Spring scopes for Span (and Trace if possible) #144
Comments
After #711 , I think that this will now be solved via |
Depends.. if these variables are to be propagated out of process to the
next hop, yes. Tomorrow, I will update the description of
openzipkin/brave#577 mentioning local propagation
as some have asked for things like span name for correlation purposes. What
is different is that this could be correlated data but not data necessary
or helpful to send to the next node (as it is not trace scoped)
…On 21 Jan 2018 9:40 pm, "Marcin Grzejszczak" ***@***.***> wrote:
After #711
<#711> , I
think that this will now be solved via ExtraFieldPropagation.set and
ExtraFieldPropagation.get. If the fields are not set in the whitelist of
headers then they will not be propagated. WDYT @adriancole
<https://github.com/adriancole> ?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#144 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAD61wGkVvo4R72a8q-JHxD6ZmmVU0kSks5tMz5egaJpZM4HUSK3>
.
|
huge redo of the openzipkin/brave#577 description complete |
Anyways, I guess this problem will be moved to Brave. I'll close this one in favour of openzipkin/brave#577 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Working on a similar problem I encountered the need to set and have access to some variables that should live only for the Span of an operation.
Eg: storing some header information that arrives from a jms message, without having access to a Session or Request scope.
I resolved to use a (Named)InheritableThreadLocal element inside a component, but this could be solved by adding a custom scope, that if a request comes from http overlaps the Request scope, but is available even if a request comes from a jms (or other) calls:
Custom scope for JMS
The text was updated successfully, but these errors were encountered: