Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix pageable processing when querymap present. #843

Merged
merged 2 commits into from
Mar 6, 2023

Conversation

OlgaMaciaszek
Copy link
Collaborator

No description provided.

@OlgaMaciaszek OlgaMaciaszek added the bug Something isn't working label Mar 3, 2023
@OlgaMaciaszek OlgaMaciaszek linked an issue Mar 3, 2023 that may be closed by this pull request
@OlgaMaciaszek
Copy link
Collaborator Author

Fixes gh-842.

@codecov
Copy link

codecov bot commented Mar 3, 2023

Codecov Report

Merging #843 (5bc28fa) into main (23ca17d) will decrease coverage by 4.99%.
The diff coverage is 90.90%.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff              @@
##               main     #843      +/-   ##
============================================
- Coverage     79.04%   74.06%   -4.99%     
- Complexity      552      571      +19     
============================================
  Files            68       69       +1     
  Lines          2090     2263     +173     
  Branches        285      306      +21     
============================================
+ Hits           1652     1676      +24     
- Misses          288      424     +136     
- Partials        150      163      +13     
Impacted Files Coverage Δ
...ork/cloud/openfeign/support/SpringMvcContract.java 88.20% <90.90%> (+0.03%) ⬆️
.../loadbalancer/FeignBlockingLoadBalancerClient.java 72.72% <0.00%> (-11.00%) ⬇️
...ncer/RetryableFeignBlockingLoadBalancerClient.java 64.54% <0.00%> (-9.95%) ⬇️
...k/cloud/openfeign/FeignCircuitBreakerTargeter.java 64.86% <0.00%> (-8.47%) ⬇️
...mework/cloud/openfeign/FeignAutoConfiguration.java 84.21% <0.00%> (-6.46%) ⬇️
...rk/cloud/openfeign/support/AbstractFormWriter.java 54.16% <0.00%> (-1.84%) ⬇️
...cloud/openfeign/support/PageableSpringEncoder.java 81.57% <0.00%> (-1.76%) ⬇️
...enfeign/support/PageableSpringQueryMapEncoder.java 83.33% <0.00%> (-1.52%) ⬇️
...amework/cloud/openfeign/FeignClientsRegistrar.java 78.22% <0.00%> (-1.49%) ⬇️
...d/openfeign/support/FeignHttpClientProperties.java 94.18% <0.00%> (-0.94%) ⬇️
... and 36 more

@OlgaMaciaszek OlgaMaciaszek marked this pull request as ready for review March 6, 2023 13:10
@OlgaMaciaszek OlgaMaciaszek merged commit f61ca17 into main Mar 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

SpringQueryMap is ignored when used with Pageable
1 participant