Cleanup in it utilities 6 #1770
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wind57
commented
Oct 16, 2024
| String version = StreamUtils.copyToString(in, StandardCharsets.UTF_8); | ||
| if (StringUtils.hasText(version)) { | ||
| version = version.trim(); | ||
| if (POM_VERSION == null) { |
There was a problem hiding this comment.
nitpick improvement, don't read pom version all the time by loading that file, but do it only once, per vm
wind57
commented
Oct 16, 2024
| @@ -149,6 +149,11 @@ public static void loadImage(String image, String tag, String tarName, K3sContai | |||
| * either get the tar from '/tmp/docker/images', or pull the image. | |||
| */ | |||
| public static void load(K3sContainer container, String tarName, String imageNameForDownload, String imageVersion) { | |||
|
|
|||
| if (imageAlreadyInK3s(container, tarName)) { | |||
There was a problem hiding this comment.
if the image is already inside the container, skip. We already had this, but for busybox only. This generalizes it for all images (also it does it according to your comment in a previous PR, thx for that btw!)
|
@ryanjbaxter last one for today. thank you |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.