Cleanup in it utilities 4 #1768
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@ryanjbaxter almost done with cleaning Commons, thank you. |
|
Why do we no longer need to call |
|
this method is only used for our, spring-cloud images, and initially I thought that there are going to be so many integration tests that they will start eating up space, and we will need to cleanup. This was never the case, its actually in reverse, we try to lower the number of images we load via the refactoring work that was started. In simpler words, this does the cleanup inside the K3S, but we do not need it at all. Besides that, it was never used in a consistent manner, some tests were using it, some not. |
|
Is it saving a lot of time? |
|
Tbh, no, not really. I just find it cleaner this way, we dont have to reason why that code is in place |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.