Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade org.wiremock dependency #1599

Merged
merged 135 commits into from
Mar 14, 2024

Conversation

wind57
Copy link
Contributor

@wind57 wind57 commented Mar 13, 2024

No description provided.

wind57 and others added 30 commits December 4, 2021 07:59
@wind57
Copy link
Contributor Author

wind57 commented Mar 13, 2024

fixes this one : #1598

because it is not a simple upgrade, requires one more tiny change

@wind57 wind57 changed the title Upgrade wiremock to 2.35.1 Upgrade org.wiremock dependency Mar 14, 2024
@@ -213,8 +213,8 @@
</dependency>

<dependency>
<groupId>com.github.tomakehurst</groupId>
<artifactId>wiremock-jre8-standalone</artifactId>
<groupId>org.wiremock</groupId>
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

change from com.github.tomakehurst:wiremock-jre8-standalone to org.wiremock:wiremock-standalone.

All other changes are some minor test simplifications and dependency change.

If you decide to merge this, we should close :

#1598

#1439

@wind57 wind57 marked this pull request as ready for review March 14, 2024 13:26
@wind57
Copy link
Contributor Author

wind57 commented Mar 14, 2024

@ryanjbaxter I saw yesterday that dependabot tried to upgrade wiremock and that the build failed and this kind of made me tick my eye, thus this PR came to life.

@ryanjbaxter ryanjbaxter added dependencies Pull requests that update a dependency file and removed waiting-for-triage labels Mar 14, 2024
@ryanjbaxter ryanjbaxter added this to the 3.1.1 milestone Mar 14, 2024
@ryanjbaxter
Copy link
Contributor

Thanks I saw this as well and was going to take a look

@ryanjbaxter ryanjbaxter merged commit 19fa6ab into spring-cloud:main Mar 14, 2024
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants