Align fabric8 k8s discovery clients part 5 #1506
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…fabric8-k8s-discovery-clients-part-2
…fabric8-k8s-discovery-clients-part-4
…fabric8-k8s-discovery-clients-part-5
wind57
commented
Nov 15, 2023
| @@ -57,7 +56,7 @@ class KubernetesClientConfigServerBootstrapper extends KubernetesConfigServerBoo | |||
|
|
|||
| @Override | |||
| public void initialize(BootstrapRegistry registry) { | |||
| if (!ClassUtils.isPresent("org.springframework.cloud.config.client.ConfigServerInstanceProvider", null)) { | |||
There was a problem hiding this comment.
this method hasConfigServerInstanceProvider is already present in the base class and it's already doing the same exact check, so just replace with that one
wind57
commented
Nov 15, 2023
| @@ -96,7 +95,7 @@ public List<ServiceInstance> apply(String serviceId, Binder binder, BindHandler | |||
| .getInstances(serviceId); | |||
| } | |||
|
|
|||
| protected KubernetesConfigServerInstanceProvider getInstanceProvider( | |||
| private KubernetesConfigServerInstanceProvider getInstanceProvider( | |||
There was a problem hiding this comment.
class is final, so protected can be replaced with private
wind57
commented
Nov 15, 2023
| @@ -116,12 +115,12 @@ protected KubernetesConfigServerInstanceProvider getInstanceProvider( | |||
|
|
|||
| String namespace = getInformerNamespace(kubernetesNamespaceProvider, discoveryProperties); | |||
| SharedInformerFactory sharedInformerFactory = new SharedInformerFactory(apiClient); | |||
| final GenericKubernetesApi<V1Service, V1ServiceList> servicesApi = new GenericKubernetesApi<>( | |||
There was a problem hiding this comment.
nothing changed here, just dropped final
wind57
commented
Nov 15, 2023
| /** | ||
| * Prefix of the properties. | ||
| */ | ||
| public static final String PREFIX = "spring.cloud.kubernetes.discovery"; |
There was a problem hiding this comment.
prefix here so that it can be re-used
|
@ryanjbaxter one more in the same direction... thank you. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.