Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

simplify clean-up of space stage #1460

Merged
merged 2 commits into from
Sep 28, 2023
Merged

simplify clean-up of space stage #1460

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f4d403f
test
wind57 Sep 28, 2023
53a2733
fix
wind57 Sep 28, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 1 addition & 9 deletions .github/workflows/composites/clean-space/action.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,15 +9,7 @@ runs:

- name: manually remove gcloud
shell: bash
run: |
gcloud_sdk_root=$(gcloud info --format='value(installation.sdk_root)')
gcloud_global_config=$(gcloud info --format='value(config.paths.global_config_dir)')

echo "will remove directory : $gcloud_sdk_root"
echo "will remove directory : $gcloud_global_config"

sudo rm -fr $gcloud_sdk_root
sudo rm -fr $gcloud_global_config
run: sudo apt-get remove google-cloud-cli
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I figured out the problem. github actions started packaging google-cloud-cli, not google-cloud-sdk (that jlumbroso/free-disk-space uses). As such, instead of manually removing, we can remove the correct package. This does not change anything, it simply simplifies the code a bit


- name: same as 'large-packages' but without 'google-cloud-sdk'
shell: bash
Expand Down