Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix build failure related to stale versions in the cache #1449

Merged
merged 2 commits into from
Sep 25, 2023
Merged

fix build failure related to stale versions in the cache #1449

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
14f9d00
fix
wind57 Sep 22, 2023
f3e0aad
fix
wind57 Sep 24, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .github/workflows/composites/maven-build-with-dry-run-for-tests/action.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,13 +4,13 @@ runs:
using: "composite"
steps:

- name: run 'package' on the project
- name: run 'install' on the project
shell: bash
run: |
./mvnw install -B \
-Dskip.build.image=true \
-DskipTests -DskipITs \
-T 1C -q
-T 1C -U -q
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Doesn't -U tell maven to update dependencies?

Copy link
Contributor Author

@wind57 wind57 Sep 25, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes, but this is what we want here, since we already restored the cache at this point. So this just updates potentially libraries that are not part of our maven reactor, which is good. it's like we update spring-boot-XXX-SNAPSHOT in this step, but not spring-cloud-kubernetes-commons-SNAPSHOT, if it makes sense

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense. I will just point out there is the potential...due to bad timing that we could finish the build locally and install those snapshots but inbetween that time and this command we could publish new snapshots to repo.spring.io and pull down those as well (for k8s). Although the chance of that is quite small and I am not sure there is anything we can really do about it.


- name: find all classpath entries
shell: bash
Expand Down
5 changes: 5 additions & 0 deletions .github/workflows/composites/pre-test-actions/action.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,11 @@ runs:
- name: cache local maven repository
uses: ./.github/workflows/composites/cache

- name: build project
shell: bash
run: |
./mvnw clean install -Dskip.build.image=true -DskipITs -DskipTests -T1C -U -B -q

- name: build controllers project
uses: ./.github/workflows/composites/build-controllers-project

Expand Down
Loading