Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor stages that have to download docker images #1429

Merged

Conversation

wind57
Copy link
Contributor

@wind57 wind57 commented Aug 31, 2023

No description provided.

@wind57 wind57 changed the title test refactor stages that have to download docker images Aug 31, 2023
@wind57
Copy link
Contributor Author

wind57 commented Aug 31, 2023

here is what we currently do in simple words:

  • build docker images that we need (1)
  • save into a cache (2)
  • in testing steps download docker images from the cache (3)

Why do we do it likes this?
No real reason, historically this is how it used to be done when we had circleci. circleci, unlike github actions, had some features that would make this choice a very good one. As we see, github actions keeps on failing for us.

So why not delete these steps (2) and (3) and move (1) into the testing steps? That is entirely doable, but doesn't that mean that we will increase the build times?

Well, no. Since we run tests in parallel, the time is going to stay the same, and this is what we see also: the times are almost the same with this change and without it.

@wind57 wind57 marked this pull request as ready for review August 31, 2023 07:49
Copy link
Contributor

@ryanjbaxter ryanjbaxter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That makes sense :)

@ryanjbaxter ryanjbaxter added this to the 3.0.5 milestone Aug 31, 2023
@ryanjbaxter ryanjbaxter merged commit 7b4f653 into spring-cloud:3.0.x Aug 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
No open projects
Status: Done
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants