Simply k8s client configmap event reload it (7) #1425
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ly-k8s-client-catalog-watcher-it
…figmap-event-reload-it
wind57
commented
Sep 11, 2023
| @@ -625,10 +627,11 @@ private boolean isDeploymentReady(String deploymentName, String namespace) throw | |||
| return availableReplicas != null && availableReplicas >= 1; | |||
| } | |||
|
|
|||
| private static void waitForDeploymentAfterPatch(String deploymentName, String namespace) { | |||
| private static void waitForDeploymentAfterPatch(String deploymentName, String namespace, | |||
There was a problem hiding this comment.
this makes this method "stronger", meaning it makes it far more reliable in terms of knowing when it is safe to start assertions after a patch. I was forced to add labels in here and look for pods because I was having problems with tests
|
this PR goes in the same direction of changing the way we test via |
|
@ryanjbaxter one more refactor, things will get somehow more fun soon, when I remove integrations tests. Thank you |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.