Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MVC Form URL encoded functionality is broken #3094

Closed
spencergibb opened this issue Oct 9, 2023 · 1 comment
Closed

MVC Form URL encoded functionality is broken #3094

spencergibb opened this issue Oct 9, 2023 · 1 comment
Assignees
@spencergibb
Labels
bug
Milestone
4.1.0-RC1

Comments

@spencergibb
Copy link
Member

See spring-projects/spring-framework#31327

The body used to be reconstructed, but it isn't anymore, breaking the proxy functionality.
@spencergibb spencergibb added the bug label Oct 9, 2023
@spencergibb spencergibb added this to the 4.1.0-RC1 milestone Oct 9, 2023
@spencergibb spencergibb self-assigned this Oct 9, 2023
spencergibb added a commit that referenced this issue Oct 9, 2023
@spencergibb
Disables ServerMvcIntegrationTests.formUrlencodedWorks()
5a9b234 
See gh-3094
@spencergibb spencergibb changed the title MVC Form URL encoded test is broken MVC Form URL encoded functionality is broken Oct 11, 2023
@spencergibb spencergibb moved this to In Progress in 2023.0.0-RC1 Oct 11, 2023
@spencergibb
Copy link
Member Author

spencergibb commented Oct 11, 2023 •
edited
Loading

Turns out, gateway mvc was never sending the body of form urlencoded posts, but as query parameters (something servlet containers do). Then, on the other side framework was recreating the body until recently which caused the test to fail and expose the bug.

@github-project-automation github-project-automation bot moved this from In Progress to Done in 2023.0.0-RC1 Oct 11, 2023
@rworsnop rworsnop mentioned this issue Aug 26, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@spencergibb spencergibb

Labels
bug
Projects
No open projects
2023.0.0-RC1
Status: Done
Milestone
4.1.0-RC1
Development

No branches or pull requests
1 participant
@spencergibb