Use Locale.ROOT when user toUpperCase or toLowerCase #6049
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cppwfs
changed the title
corneil
reviewed
Nov 6, 2024
| @@ -52,7 +53,7 @@ public class PostgreSQLTextToOID { | |||
| public static void convertColumnToOID(String table, String id, String column, DataSource dataSource) { | |||
|
|
|||
| try (Connection connection = dataSource.getConnection()) { | |||
| try (ResultSet resultSet = connection.getMetaData().getColumns(null, null, table.toUpperCase(), column.toUpperCase())) { | |||
| try (ResultSet resultSet = connection.getMetaData().getColumns(null, null, table.toUpperCase(Locale.ROOT), column.toUpperCase())) { | |||
There was a problem hiding this comment.
You missed the colum.toUpperCase()
corneil
reviewed
Nov 6, 2024
| @@ -90,7 +91,7 @@ public static void convertColumnToOID(String table, String id, String column, Da | |||
|
|
|||
| public static void convertColumnFromOID(String table, String id, String column, DataSource dataSource) { | |||
| try (Connection connection = dataSource.getConnection()) { | |||
| try (ResultSet resultSet = connection.getMetaData().getColumns(null, null, table.toUpperCase(), column.toUpperCase())) { | |||
| try (ResultSet resultSet = connection.getMetaData().getColumns(null, null, table.toUpperCase(), column.toUpperCase(Locale.ROOT))) { | |||
There was a problem hiding this comment.
You missed table.toUpperCase()
There was a problem hiding this comment.
WOOT WOOT! Great Catches!
resolves spring-cloud#6048 Signed-off-by: Glenn Renfro <[email protected]> Update code based on code review Add to missing Locale.ROOT values to the toUpperCase Signed-off-by: Glenn Renfro <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #6048