Skip to content

Commit

Permalink
Remove deprecations from AppRegistryController
Browse files Browse the repository at this point in the history
The original issue states to remove deprecated functions.
However, this would remove some of SCDF's default behavior when registering applications.
In that it can look the suffix of the URL to obtain the version.
The original Issues for the PR that put in the deprecations just wanted to give the
user the ability to override the version.

Also deprecated the use of bootVersion when registering an app.

Resolves #6011

Signed-off-by: Glenn Renfro <[email protected]>
  • Loading branch information
cppwfs committed Oct 30, 2024
1 parent 1a10c23 commit 7a4d132
Showing 1 changed file with 2 additions and 5 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -170,7 +170,6 @@ public DetailedAppRegistrationResource info(@PathVariable ApplicationType type,
return getInfo(type, name, version, exhaustive);
}

@Deprecated
@GetMapping("/{type}/{name}")
@ResponseStatus(HttpStatus.OK)
public DetailedAppRegistrationResource info(
Expand Down Expand Up @@ -224,7 +223,7 @@ else if (entry.getKey().equals("outbound")) {
* @param type module type
* @param name module name
* @param version module version
* @param bootVersion module boot version or {@code null} to use the default
* @param bootVersion module boot version or {@code null} to use the default. Deprecated: bootVersion is no longer needed when registering an app.
* @param uri URI for the module artifact (e.g. {@literal maven://group:artifact:version})
* @param metadataUri URI for the metadata artifact
* @param force if {@code true}, overwrites a pre-existing registration
Expand All @@ -235,7 +234,7 @@ public void register(
@PathVariable ApplicationType type,
@PathVariable String name,
@PathVariable String version,
@RequestParam(required = false) String bootVersion,
@RequestParam(required = false) @Deprecated String bootVersion,
@RequestParam String uri,
@RequestParam(name = "metadata-uri", required = false) String metadataUri,
@RequestParam(defaultValue = "false") boolean force) {
Expand All @@ -260,7 +259,6 @@ public void register(
}
}

@Deprecated
@PostMapping("/{type}/{name}")
@ResponseStatus(HttpStatus.CREATED)
public void register(
Expand Down Expand Up @@ -375,7 +373,6 @@ private String findStreamContainingAppOf(ApplicationType appType, String appName
return null;
}

@Deprecated
@DeleteMapping("/{type}/{name}")
@ResponseStatus(HttpStatus.OK)
public void unregister(@PathVariable ApplicationType type, @PathVariable String name) {
Expand Down

0 comments on commit 7a4d132

Please sign in to comment.