Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: use withLogger of RetryTemplateBuilder to avoid reflections #2545

Merged
merged 1 commit into from
Oct 23, 2024

Conversation

klopfdreh
Copy link
Contributor

@klopfdreh klopfdreh commented Sep 19, 2024

This PR is using the new withLogger method of RetryTemplateBuilder to avoid reflections.

WARNING: spring-retry needs to be released with version 2.0.10 first.

fixes: #2544

@klopfdreh klopfdreh changed the title fix: use setter of logger for RetryTemplate fix: use withLogger of RetryTemplateBuilder to avoid reflections Sep 19, 2024
@ryanjbaxter
Copy link
Contributor

Can you let us know once spring-retry 2.0.10 is released?

@klopfdreh
Copy link
Contributor Author

Sure - I am going to ping you here when the new version is released.

@klopfdreh
Copy link
Contributor Author

@ryanjbaxter - Spring Retry 2.0.10 is released - the PR should work now 👍

@ryanjbaxter
Copy link
Contributor

@klopfdreh thanks for the heads up, can you merge in the latest changes from 4.1.x and push them to your branch?

@klopfdreh klopfdreh force-pushed the fix/retrytemplatelogger branch from 6323ae3 to 9815ac0 Compare October 18, 2024 19:33
@klopfdreh
Copy link
Contributor Author

Build was successful.

@ryanjbaxter ryanjbaxter merged commit 6777171 into spring-cloud:4.1.x Oct 23, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use RetryTemplateBuilder.withLogger to set the logger instead of reflections
3 participants