Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add API To Config Server To Return Configuration Only For Profiles #2291

Open
ryanjbaxter opened this issue Jun 16, 2023 · 1 comment
Open

Add API To Config Server To Return Configuration Only For Profiles #2291

ryanjbaxter opened this issue Jun 16, 2023 · 1 comment
Labels
enhancement

Comments

@ryanjbaxter
Copy link
Contributor

Spring Boots Config Data support separates loading config data into two steps, configuration data without profiles and then configuration with profiles. We try our best to label PropertySources as PROFILE_SPECIFIC in ConfigServerConfigDataLoader but its error prone because depending on the configuration of the config server the profile separator could be anything. AWS Secrets Manage, AWS Parameter Store and Vault all allow for profile separator configuration.

We know when the config data API is only requesting profile specific property sources so we could make a specific request to the config server to just return the profile specific property sources.
ryanjbaxter added a commit to ryanjbaxter/spring-cloud-config that referenced this issue Jun 16, 2023
@ryanjbaxter
Revert changes to adding profile specific logic
000673d 
Fixes spring-cloud#2279
Fixes spring-cloud#2289

See spring-cloud#2291
ryanjbaxter added a commit to ryanjbaxter/spring-cloud-config that referenced this issue Jun 16, 2023
@ryanjbaxter
Revert changes to adding profile specific logic
a120ba3 
Fixes spring-cloud#2279
Fixes spring-cloud#2289

See spring-cloud#2291
@ryanjbaxter ryanjbaxter mentioned this issue Jun 16, 2023
Merged
ryanjbaxter added a commit to ryanjbaxter/spring-cloud-config that referenced this issue Jun 16, 2023
@ryanjbaxter
Revert changes to adding profile specific logic
cf3cb78 
Fixes spring-cloud#2279
Fixes spring-cloud#2289

See spring-cloud#2291
@ryanjbaxter
Copy link
Contributor Author

See spring-projects/spring-boot#25766
spring-projects/spring-boot@5774ea3

ryanjbaxter added a commit that referenced this issue Jun 16, 2023
@ryanjbaxter
Revert changes to adding profile specific logic (#2292)

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
GPG key ID: 4AEE18F83AFDEB23
Expired
Verified
Learn about vigilant mode
640d6d3 
Fixes #2279
Fixes #2289

See #2291

Co-authored-by: Ryan Baxter <[email protected]>
This was referenced Jul 3, 2024
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@ryanjbaxter