Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add the ability for FailsafeTextEncryptor to have a delegate. #1349

Merged
merged 1 commit into from
Apr 5, 2024
Merged

Add the ability for FailsafeTextEncryptor to have a delegate. #1349

merged 1 commit into from
Apr 5, 2024

Conversation

ryanjbaxter
Copy link
Contributor

@ryanjbaxter ryanjbaxter added this to the 4.1.3 milestone Apr 4, 2024
@ryanjbaxter ryanjbaxter requested a review from spencergibb April 4, 2024 18:10
@ryanjbaxter ryanjbaxter mentioned this pull request Apr 4, 2024
Merged
spencergibb
spencergibb approved these changes Apr 5, 2024
View reviewed changes
Copy link
Member

@spencergibb spencergibb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe document here why a delegate, since it's odd without context.

@ryanjbaxter ryanjbaxter force-pushed the failsafetextencryptor-delegate branch from 9fbfc98 to 338938e Compare April 5, 2024 20:00
@ryanjbaxter ryanjbaxter merged commit 77d221d into spring-cloud:main Apr 5, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@spencergibb spencergibb spencergibb approved these changes

Assignees
No one assigned
Labels
enhancement
Projects
No open projects
2023.0.2
Status: Done
Milestone
4.1.3
Development

Successfully merging this pull request may close these issues.
2 participants
@ryanjbaxter @spencergibb