Use SmartInitializingSingleton instead of BeanPostProcessor to set up @LoadBalanced WebClient.Builder. #1319
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
OlgaMaciaszek
requested review from
spencergibb,
ryanjbaxter and
marcingrzejszczak
ryanjbaxter
reviewed
Jan 12, 2024
| * @author Olga Maciaszek-Sharma | ||
| * @since 4.1.0 | ||
| */ | ||
| public class LoadBalancerRestClientBuilderBeanPostProcessor implements BeanPostProcessor { |
There was a problem hiding this comment.
I dont think we can delete this public class in a minor release
There was a problem hiding this comment.
Right. I don't think anyone would use it after those changes, but you're right. Will change that.
ryanjbaxter
approved these changes
Jan 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes gh-1315.