-
Notifications
You must be signed in to change notification settings - Fork 269
Access Ads On The Facebook Graph API #3
base: master
Are you sure you want to change the base?
Conversation
I didn't see this until submitting my pull request for what appears to be a subset of nearly the same functionality. I'm interested in digging into this code to see your approach. |
Hi Will Taylor, I'd appreciate your comments on the approach taken here, which is very much along the lines of the existing social template. The code can be broken down into pieces that define:
In addition, I added some new functionality in the core API to:
I haven't dug into your code in detail, but I like the fact that you use mock JSON objects for testing. I, on the other hand, make my test case hit the Facebook Ads API directly. While I haven't been able to automate that part yet (since it requires a whitelisted valid access token and account id), it helps ensure that there's no gap between the client and their server. Not sure what the right testing approach should be. At any rate, please take a look at the code (and I yours), and hopefully, we can put together something that Craig will find acceptable. Best Regards, |
Just an update, the features in this pull request have been more or less fleshed out. Note that it includes certain generic (i.e., not specific to ads) features, such as search operations, connection operations, page post retrievals, image uploads, among other things. I look forward to your comments and suggestions. |
Hi Karthick. I was on vacation last week and am just getting back to work and getting caught up. I hope to have some time to look into your code in the next few days and continue this discussion. Thanks! |
Hi Karthick. It looks like this pull request was not picked up. Any idea why? |
Eric: Put simply, it wasn't picked up because I've been otherwise engaged for the past several months and haven't had opportunity to review it and merge it into Spring Social Facebook. But I am actively working on some updates for Spring Social (Core|Facebook|Twitter) right now to be part of 1.1.0.M1 (hopefully in time for S2GX in October). This pull request is scheduled to be merged in for 1.1.0.M2 which will naturally follow the M1 release. |
Hi Craig! We've done a lot of work internally at my company on the Ads API within an internally-forked version of spring-social-facebook. Is it possible for us to have an offline conversation to discuss how we might get our changes merged in? It's not exactly compatible with karthicks' work, and not exactly compatible with willtaylor's work either (although it is based on Will's work). |
Eric: I'll be happy to consider any pull request. Feel free to submit it as a pull request on GitHub and I'll try to find a time to review it and merge it in for Spring Social Facebook 1.1.0. Be aware, however, that while I hope to get Ads API covered for Spring Social Facebook 1.1.0, it's not one of the higher priority items right now and I've got an already ambitious list of things to attack for 1.1.0.M1. And I am aiming to release 1.1.0.M1 in time for SpringOne/2GX in the middle of October. The one thing that will keep that from happening is that I also have a couple of presentations that I must finish preparing for S2GX, so I have to cleverly budget my time. But I'm still hopeful that I can cut some form of 1.1.0.M1 release around the S2GX timeframe. Here's how to increase the likelihood that your pull request will be merged sooner rather than later:
The more stuff from this list that you are missing requires more work on my part to review and build tests around the pull request before merging it...and with the other stuff in my queue, I'll likely just set your pull request aside until I have more time. |
Eric (and anyone else who wants to contribute): Another thing to help move this along is to sign the contributor agreement at https://support.springsource.com/spring_committer_signup if you've not done so already. It makes the legal-minded people around here happy and makes my job easier in case they ask about it. |
Any update on merging ads api? |
Hi guys, |
@karthicks Please sign the Contributor License Agreement! Click here to manually synchronize the status of this Pull Request. See the FAQ for frequently asked questions. |
More often than not, the Facebook Graph API is used to access users, statuses, events and what-not. In addition, it comes with a Ads API that specifically deals with ads, which can be used to "automate the creation of ads campaigns on Facebook, as well as measure the performance of ad campaigns".
Herein, we propose extending the Spring Social Facebook project to handle Facebook Ads through the Graph API (as opposed to their legacy REST API), by leveraging the existing framework that's already in place. In particular, we'll talk about the abstract models and operations, followed by their concrete template and format definitions. Last but not the least, we'll go into certain generic features that we feel belong in the Graph API layer.
The goal of the patch that will follow is primarily to (a) serve as a starting point (b) invite inputs on design approach and (c) allow the community at large to work on this together. In other words, this is a work in progress.