Skip to content
This repository has been archived by the owner on Feb 23, 2020. It is now read-only.

UpdateShipment has incomplete error message if shipment items do not match #69

Open
MisinformedDNA opened this issue Jan 27, 2015 · 0 comments
Open

UpdateShipment has incomplete error message if shipment items do not match #69

MisinformedDNA opened this issue Jan 27, 2015 · 0 comments

Comments

@MisinformedDNA
Copy link
Contributor

The code here, verifies that received shipment items is a superset of the shipment in the order, but it does not check that the sets are equal.

So if I order product A and B and only product A gets shipped, then Spree will be told that the entire order was shipped when it was not.
@MisinformedDNA MisinformedDNA changed the title UpdateShipment has imcomplete error message if shipment items do not match UpdateShipment has incomplete error message if shipment items do not match Jan 27, 2015
jordan-brough pushed a commit to jordan-brough/spree_wombat that referenced this issue May 19, 2015
Merge pull request spree#69 from bonobos/canceled_qty
6b4c73d 
Add canceled quantity to line item serializer. Clean up specs
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@MisinformedDNA